Skip to content

Conversation

petyaslavova
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@petyaslavova petyaslavova requested review from valkirilov and removed request for valkirilov August 28, 2025 07:09
@petyaslavova petyaslavova requested a review from Copilot August 29, 2025 08:28
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds end-to-end scenario tests for Redis Enterprise maintenance push notifications handling, specifically for hitless upgrade scenarios involving cluster operations.

  • Implements comprehensive scenario tests for migration and bind operations with push notifications
  • Adds helper classes for cluster operations and client validations
  • Updates configuration to support the new testing framework

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/test_scenario/test_hitless_upgrade.py Main test file implementing e2e tests for maintenance push notifications during cluster operations
tests/test_scenario/hitless_upgrade_helpers.py Helper classes for cluster operations and client validations
tests/test_scenario/conftest.py Test configuration and fixtures for Redis client setup
redis/maintenance_events.py Updates default relax_timeout value from 20 to 10 seconds
redis/connection.py Refactors connection parameter handling for maintenance events

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +1835 to +1836
# if orig_host_address is None it means we haven't
# configured the original values yet
Copy link
Preview

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should use proper capitalization: "If orig_host_address is None it means we haven't configured the original values yet"

Suggested change
# if orig_host_address is None it means we haven't
# configured the original values yet
# If orig_host_address is None, it means we haven't configured the original values yet

Copilot uses AI. Check for mistakes.

Base automatically changed from feat/hitless-upgrade-sync-standalone to master August 29, 2025 11:06
@petyaslavova
Copy link
Collaborator Author

Closing this PR. New one is posted that has been started from master and is without conflicts --> #3758

@petyaslavova petyaslavova deleted the ps_adding_hitless_e2e_tests branch August 29, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants