-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Adding e2e scenario tests for maintenance push notifications handling. #3755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… host:port info. (#3751)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds end-to-end scenario tests for Redis Enterprise maintenance push notifications handling, specifically for hitless upgrade scenarios involving cluster operations.
- Implements comprehensive scenario tests for migration and bind operations with push notifications
- Adds helper classes for cluster operations and client validations
- Updates configuration to support the new testing framework
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
tests/test_scenario/test_hitless_upgrade.py | Main test file implementing e2e tests for maintenance push notifications during cluster operations |
tests/test_scenario/hitless_upgrade_helpers.py | Helper classes for cluster operations and client validations |
tests/test_scenario/conftest.py | Test configuration and fixtures for Redis client setup |
redis/maintenance_events.py | Updates default relax_timeout value from 20 to 10 seconds |
redis/connection.py | Refactors connection parameter handling for maintenance events |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
# if orig_host_address is None it means we haven't | ||
# configured the original values yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment should use proper capitalization: "If orig_host_address is None it means we haven't configured the original values yet"
# if orig_host_address is None it means we haven't | |
# configured the original values yet | |
# If orig_host_address is None, it means we haven't configured the original values yet |
Copilot uses AI. Check for mistakes.
Closing this PR. New one is posted that has been started from master and is without conflicts --> #3758 |
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.