-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Reorganizing the code related to maintenance push notifications. #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Reorganizing the code related to maintenance push notifications. #3785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reorganizes the maintenance push notifications code by extracting logic into separate abstract classes and using multiple inheritance to expose maintenance push notifications for existing Connection
and ConnectionPool
classes.
- Introduced abstract classes for maintenance push notifications functionality
- Updated connection handling to use the new
_get_socket()
method instead of direct_sock
access - Modified test configurations to support cache configurations and different connection types
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
tests/test_maint_notifications_handling.py | Updated test methods to use new socket access patterns and added cache configuration support |
tests/test_maint_notifications.py | Added socket import and updated MockConnection to inherit from new abstract class |
redis/maint_notifications.py | Updated type hints to use new MaintNotificationsAbstractConnection instead of ConnectionInterface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
feeed3f
to
97bd380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…classes. Usingle multiple inheritance for Connection and ConnectionPool classes to expose the maintenance push notifications for the existing connections.
c30f625
to
7f99734
Compare
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Extracting maintenance push notifications logic into separate abstract classes. Using multiple inheritance for
Connection
andConnectionPool
classes to expose the maintenance push notifications for the existing connections.