typing: Fix signature of Redis.transaction#4002
Open
stephenfin wants to merge 1 commit intoredis:masterfrom
Open
typing: Fix signature of Redis.transaction#4002stephenfin wants to merge 1 commit intoredis:masterfrom
stephenfin wants to merge 1 commit intoredis:masterfrom
Conversation
The return type depends on the value of the value_from_callable kwarg. Indicate this with type hinting. Signed-off-by: Stephen Finucane <stephen@that.guru>
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Collaborator
|
Hi @stephenfin , thank you for your contribution! We will have a look at it. |
fernando1508
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The return type depends on the value of the
value_from_callablekwarg. Indicate this with type hinting.Pull Request check-list
Note
Low Risk
Type-only API signature changes to
Redis.transaction; runtime behavior is effectively unchanged aside from accepting explicit keyword parameters instead of popping them from**kwargs. Low risk unless callers relied on passing these options only via**kwargsin unusual ways.Overview
Improves type hints for
Redis.transactionso its return type is conditional onvalue_from_callable(returnsList[Any]when false, otherwise returns the callable’s genericT) via@overload+TypeVar.Updates the runtime signature to expose
shard_hint,value_from_callable, andwatch_delayas explicit keyword parameters (instead of pulling them out of**kwargs), tightening typing around watches and keyword arguments.Written by Cursor Bugbot for commit 03d11c4. This will update automatically on new commits. Configure here.