Add ability to set TTL for hash fields, HEXPIRE
#1324
Merged
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Please let me know if there is any improvement to the PR I can do in order to get this merged in. |
byroot
reviewed
Oct 30, 2025
test/lint/hashes.rb
Outdated
| assert_equal [1], r.hexpire("foo", 1, "f1") | ||
| assert r.hexists("foo", "f1") | ||
|
|
||
| sleep(1) |
Collaborator
There was a problem hiding this comment.
Sleeping in test suite is always a bad idea.
A better way to test hexpire is to implement httl, and use it to check the TTL changed.
Contributor
Author
There was a problem hiding this comment.
Fair enough. I've made the changes to introduce httl and used it within the hexpire test. See 3662a56
vietqhoang
added a commit
to vietqhoang/redis-rb
that referenced
this pull request
Oct 30, 2025
Context: redis#1324 (comment) `httl` documentation: https://redis.io/docs/latest/commands/httl/
Introduced in 7.4.0, https://redis.io/docs/latest/commands/hexpire/
Collaborator
|
@vietqhoang I was editing your PR, please stop pushing in your branch. |
Contributor
Author
|
Sorry, didn't catch you were also editing. Just want to note the change added to distributed The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1187
Introduced in 7.4.0, https://redis.io/docs/latest/commands/hexpire/