Skip to content

feat(MCP): Implement the base framework for a RedisVL MCP server#532

Open
vishal-bala wants to merge 10 commits intofeat/RAAE-1395-redisvl-mcpfrom
feat/RAAE-1396/mcp-framework
Open

feat(MCP): Implement the base framework for a RedisVL MCP server#532
vishal-bala wants to merge 10 commits intofeat/RAAE-1395-redisvl-mcpfrom
feat/RAAE-1396/mcp-framework

Conversation

@vishal-bala
Copy link
Collaborator

@vishal-bala vishal-bala commented Mar 12, 2026

This PR implements the base framework for a RedisVL MCP server. In this iteration, the goal is to introduce the scaffolding for the MCP server to the extent that the server is runnable but does not have any meaningful functionality.


Note

Medium Risk
Introduces a new MCP server startup/shutdown path that opens Redis connections, inspects index metadata, and instantiates vectorizers; failures here could impact runtime behavior and resource cleanup. Risk is mitigated by extensive unit/integration coverage for config validation and lifecycle handling.

Overview
Adds an initial redisvl.mcp package that makes RedisVL runnable as an MCP server via the optional mcp extra (fastmcp + pydantic-settings).

The new framework loads/validates a YAML MCP config (with ${ENV} substitution), enforces a single index binding, inspects an existing Redis search index at startup, applies schema override patches when FT.INFO is incomplete, and initializes an AsyncSearchIndex plus a configured vectorizer with concurrency/timeout guards.

Also adds a stable MCP error contract (MCPErrorCode, RedisVLMCPError, map_exception), updates import-sanity tests to skip redisvl.mcp when extras aren’t installed, and adds unit + integration tests covering config validation, schema override safety, vector dim mismatch, and resource cleanup on failure/shutdown.

Written by Cursor Bugbot for commit 08ca214. This will update automatically on new commits. Configure here.

@vishal-bala vishal-bala changed the base branch from main to feat/RAAE-1395-redisvl-mcp March 12, 2026 10:15
@jit-ci
Copy link

jit-ci bot commented Mar 12, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@vishal-bala vishal-bala changed the title Ensure MCP server always disconnects index during shutdown feat(MCP): Implement the base framework for a RediVL MCP server Mar 12, 2026
@vishal-bala vishal-bala self-assigned this Mar 12, 2026
@vishal-bala vishal-bala added the auto:minor Increment the minor version when merged label Mar 12, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf0f0895a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vishal-bala vishal-bala requested review from nkanu17 and rbs333 March 12, 2026 12:01
@vishal-bala vishal-bala changed the title feat(MCP): Implement the base framework for a RediVL MCP server feat(MCP): Implement the base framework for a RedisVL MCP server Mar 13, 2026
@vishal-bala vishal-bala force-pushed the feat/RAAE-1395-redisvl-mcp branch from 2f58b0f to 1d1e5cc Compare March 18, 2026 13:29
@vishal-bala vishal-bala force-pushed the feat/RAAE-1396/mcp-framework branch from 6b17caa to f197652 Compare March 24, 2026 12:02
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@vishal-bala vishal-bala requested a review from limjoobin March 25, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto:minor Increment the minor version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant