feat(MCP): add RedisVL MCP CLI#544
Open
vishal-bala wants to merge 3 commits intofeat/RAAE-1398/upsert-toolfrom
Open
feat(MCP): add RedisVL MCP CLI#544vishal-bala wants to merge 3 commits intofeat/RAAE-1398/upsert-toolfrom
vishal-bala wants to merge 3 commits intofeat/RAAE-1398/upsert-toolfrom
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9441c1d942
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec/MCP.mdincomplete in practice and left users without a supported way to run RedisVL as an MCP server.rvl mcpcommand, wiring in lazy optional-dependency handling, and rounding out the MCP server/config/tooling surface with tests and documentation updates.Testing
uv run python -m pytest tests/unit/test_cli_mcp.py -quv run python -m pytest tests/unit/test_mcp -quv run rvluv run rvl mcp --helpuv run rvl mcp --config /tmp/redisvl_mcp_smoke/config.yamlagainst a live Redis containeruvx --from 'redisvl[mcp]' rvl mcp --config ...currently resolves the published package, which does not yet include the new extra/CLI path, so that install-path check is not green until a release is cutNote
Medium Risk
Adds a new CLI subcommand that boots and manages an async MCP server lifecycle; failures in argument handling, optional-dependency imports, or async shutdown could impact runtime behavior, but changes are isolated to the CLI path.
Overview
Adds a new
rvl mcpCLI subcommand to run RedisVL as an MCP stdio server, including--configand--read-onlyflags and richer help/usage output.The MCP entrypoint (
redisvl/cli/mcp.py) lazily imports MCP components and optional dependencies, enforces Python >= 3.10, bridges sync CLI to async startup/serve/shutdown, and prints user-facing errors with non-zero exit codes. Unit tests cover dispatch, help output, version/dependency failure modes, and server lifecycle/shutdown behavior.Written by Cursor Bugbot for commit 9441c1d. This will update automatically on new commits. Configure here.