Switch ssh unit tests from abandonware forgery gem to Faker gem #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prahal
force-pushed
the
remove-abandoned-forgery
branch
from
2e93969 to
c51e4d6
Compare
Contributor
|
@prahal hi there! can you please rebase on master? thank you! |
prahal
force-pushed
the
remove-abandoned-forgery
branch
from
c51e4d6 to
51dc796
Compare
Contributor
Author
|
forgery abandonware removal rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test gem2deb build working.
I switched from Forgery//Name.location to Faker::Company name because it was the closest (alphanum, comma, single quotes) to https://github.com/sevenwire/forgery/blob/master/lib/forgery/dictionaries/locations
Since sshkey location is not meant to be an address "location" but a name used to store subkeys, like "desktop" or a name, and as Company name had quote, space and comma at least in the English locale I chose this one instead of Faker::Address.community that did not exist in all locales and was very simple in the English locale (alphanum and space).