Skip to content

Conversation

@rockwotj
Copy link
Contributor

5 seconds is too low for slow services

@rockwotj rockwotj requested review from a team and Copilot May 29, 2025 03:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR raises the SSE client timeout to 30 seconds for slower services and adds support for a new StreamableHTTPMCPEndpoint to communicate over HTTP streaming with the same timeout.

  • Increase SSE timeout in mcp_client to 30 seconds.
  • Introduce StreamableHTTPMCPEndpoint class and handle it in mcp_client.
  • Export StreamableHTTPMCPEndpoint in the package’s __init__.py.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/redpanda/agents/_mcp.py Bumped SSE timeout, added StreamableHTTPMCPEndpoint and its branch in mcp_client.
src/redpanda/agents/init.py Added StreamableHTTPMCPEndpoint to module exports.
Comments suppressed due to low confidence (1)

src/redpanda/agents/_mcp.py:145

  • There’s no test coverage for the new StreamableHTTPMCPEndpoint branch in mcp_client. Consider adding unit tests to exercise this path.
elif isinstance(server, StreamableHTTPMCPEndpoint):

@rockwotj rockwotj changed the title mcp: bump sse timeout mcp: bump sse timeout & add support for streamable http May 29, 2025
5 seconds is too low for slow services
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the SSE timeout to 30 seconds and adds support for streamable HTTP communication by introducing a new MCP endpoint.

  • Bump SSE client timeout from the default to 30 seconds.
  • Implement a new StreamableHTTPMCPEndpoint class using streamablehttp_client with a timedelta-based timeout.
  • Update the module exports to include the new StreamableHTTPMCPEndpoint.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/redpanda/agents/_mcp.py Added StreamableHTTPMCPEndpoint and updated mcp_client to support it.
src/redpanda/agents/init.py Exported StreamableHTTPMCPEndpoint.

@garrett-raska garrett-raska merged commit e7ffd3a into main May 29, 2025
4 checks passed
@rockwotj rockwotj deleted the timeout branch May 29, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants