Add retention setting to tx_single_reads_writes scenario #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rystsov
reviewed
Nov 9, 2022
Contributor
rystsov
left a comment
rystsov
left a comment
There was a problem hiding this comment.
it isn't so simple, we also need to read the log in the end and make sure that:
- there is a gap in the begging of what's read comparing to what's written
- what's read is what's was written
- there is no gaps after the initial gap
that logic should be in harness/chaos/workloads/tx_single_reads_writes/consistency.py it doesn't do much so you may use harness/chaos/workloads/reads_writes/consistency.py as an example
| # waiting for the controller to be up before creating a topic | ||
| self.redpanda_cluster.wait_leader("controller", namespace="redpanda", replication=len(self.redpanda_cluster.nodes), timeout_s=30) | ||
|
|
||
| retention_ms = 604800000 |
Contributor
There was a problem hiding this comment.
retention_ms = self.read_config(["retention_ms"], 604800000)
| if self.config.get("retention_ms") != None: | ||
| retention_ms = self.config["retention_ms"] | ||
|
|
||
| segment_bytes = 1073741824 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanna test how transaction works with retention
For first step we added this type of testing inside the simplest
tx_single_reads_writesscenario, because in this case we read not so far from tail. And should not read data from deleted segmentFor this we need to set small segment set for topic and also put small retention period.