-
Notifications
You must be signed in to change notification settings - Fork 4
DOC-666 cluster config in Cloud #245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
micheleRP
merged 51 commits into
main
from
DOC-666-Document-feature-Manage-form-factor-appropriate-cluster-configuration-properties-in-Console
Apr 8, 2025
Merged
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
a095083
DOC-666 cluster config in Cloud
micheleRP 813f1e9
minor edits
micheleRP c5a46da
add restart column + Wasm GA to what's new
micheleRP fda8126
move create/manage topic into Manage bucket
micheleRP 5f154ad
fix typo
micheleRP a89d19d
update local playbook + ss schema ID validation
micheleRP ba35c5e
fix title
micheleRP 45b02a1
fix playbook
micheleRP e806a58
Apply suggestions from code review
JakeSCahill 330c9fc
Apply suggestions from code review
JakeSCahill 802c567
Merge branch 'main' into DOC-666-Document-feature-Manage-form-factor-…
micheleRP e705fe7
single source audit logging + fix descriptions
micheleRP 6c92116
update what's new
micheleRP 4119118
single source data transforms
micheleRP e6bd28f
single source transforms SDK reference
micheleRP f1a8124
fix links
micheleRP 4c1ca0c
include tagged cluster properties
micheleRP 33f30f8
add SS + conditionalizing
micheleRP 4a7c30e
clean up conditionalizing
micheleRP 2762c7a
update What's New
micheleRP 43b1ec2
remove tables, since links to properties are in
micheleRP e2f0e45
minor edit
micheleRP 4d8e781
fix levels
micheleRP da55e46
conditionalize
micheleRP e23751a
test
micheleRP ebb2f40
add table back (until single sourcing works)
micheleRP 8f3197b
add topic properties reference
micheleRP c4eb0c8
typo
micheleRP 17480b6
take out note
micheleRP 7275042
remove table (since properties single source now)
micheleRP 6c1183f
update to properties supported as of 4/4
micheleRP 311d697
remove schema ID validation + undo edits
micheleRP d6b98ef
minor edits
micheleRP 710e626
Merge branch 'main' into DOC-666-Document-feature-Manage-form-factor-…
micheleRP f6d3042
Iceberg links (will resolve Monday)
micheleRP 6d6f1e5
remove topic properties reference
micheleRP 755c9a9
fix conditionals
micheleRP 7796bce
fix conditionals
micheleRP ba210fc
rerun single sourcing
micheleRP 10db5bb
fix audit_excluded_topics
micheleRP 51da140
remove audit_enabled_event_types
micheleRP a351829
Merge branch 'main' into DOC-666-Document-feature-Manage-form-factor-…
micheleRP 769a83d
change include::25.1@ROOT to include::ROOT:
micheleRP 7137477
Update modules/manage/pages/iceberg/use-iceberg-catalogs.adoc
micheleRP 37f361f
Merge branch 'main' into DOC-666-Document-feature-Manage-form-factor-…
micheleRP d697c8b
align auditing with SM directory structure
micheleRP bc11431
fix structure
micheleRP e4b214c
rerun
micheleRP 832e944
rerun
micheleRP 1fd2fe5
fix local-antora-playbook + serverless redirect
micheleRP 075b1c3
minor edit
micheleRP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Develop Data Transforms | ||
| :description: Learn how to initialize a data transforms project and write transform functions in your chosen language. | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:develop:data-transforms/build.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Configure Data Transforms | ||
| :description: pass:q[Learn how to configure data transforms in Redpanda, including editing the `transform.yaml` file, environment variables, and memory settings. This topic covers both the configuration of transform functions and the WebAssembly (Wasm) engine's environment.] | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:develop:data-transforms/configure.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = Manage Data Transforms | ||
| :description: You can monitor the status and performance metrics of your transform functions. You can also view detailed logs and delete transform functions when they are no longer needed. | ||
|
|
||
| include::ROOT:console:ui/data-transforms.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Deploy Data Transforms | ||
| :description: Learn how to build, deploy, share, and troubleshoot data transforms in Redpanda. | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:develop:data-transforms/deploy.adoc[tag=single-source] |
5 changes: 5 additions & 0 deletions
5
modules/develop/pages/data-transforms/how-transforms-work.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = How Data Transforms Work | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
| :description: Learn how Redpanda data transforms work. | ||
|
|
||
| include::ROOT:develop:data-transforms/how-transforms-work.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| = Data Transforms | ||
| :description: Learn about WebAssembly data transforms within Redpanda Cloud. | ||
| :page-layout: index |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Monitor Data Transforms | ||
| :description: This topic provides guidelines on how to monitor the health of your data transforms and view logs. | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:develop:data-transforms/monitor.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Data Transforms Quickstart | ||
| :description: Learn how to build and deploy your first transform functio.. | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:develop:data-transforms/run-transforms.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = Write Integration Tests for Transform Functions | ||
| :description: pass:q[Learn how to write integration tests for data transform functions in Redpanda, including setting up unit tests and using testcontainers for integration tests.] | ||
|
|
||
| include::ROOT:develop:data-transforms/test.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| = Manage Topics | ||
| :page-categories: Clients, Development | ||
| :page-aliases: develop:config-topics.adoc, deploy:deployment-option/cloud/create-topic.adoc | ||
| :description: Learn how to create topics, update topic configurations, and delete topics or records. | ||
|
|
||
| include::ROOT:develop:config-topics.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| = Audit Logging | ||
| :description: Learn how to use Redpanda's audit logging capabilities. | ||
| :page-categories: Management, Security | ||
| :env-linux: true | ||
|
|
||
| include::ROOT:manage:audit-logging.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Sample Audit Log Messages | ||
| :description: Sample Redpanda audit log messages. | ||
| :page-categories: Management, Security | ||
|
|
||
| include::ROOT:manage:audit-logging/audit-log-samples.adoc[tag=single-source] |
30 changes: 30 additions & 0 deletions
30
modules/manage/pages/cluster-maintenance/config-cluster.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| = Configure Cluster Properties | ||
| :description: Learn how to configure cluster properties to enable and manage features. | ||
|
|
||
| Redpanda cluster configuration properties are automatically set to the default values and are replicated across all brokers. | ||
|
|
||
| You can edit certain cluster configuration properties with the Cloud API. For example, you can enable and manage xref:manage:iceberg/about-iceberg-topics.adoc[Iceberg topics], xref:develop:data-transforms/index.adoc[data transforms], and xref:manage:audit-logging.adoc[audit logging]. | ||
|
|
||
| == Limitations | ||
|
|
||
| Cluster configuration with the Cloud API is supported on BYOC and Dedicated clusters running on AWS and GCP. | ||
|
|
||
| - It is not available on Serverless clusters. | ||
| - It is not available on BYOC and Dedicated clusters running on Azure. | ||
|
|
||
| == Set cluster configuration properties | ||
|
|
||
| You can set cluster configuration properties when you create a cluster, or you can edit an existing cluster. | ||
|
|
||
| * Create a cluster by making a xref:api:ROOT:cloud-controlplane-api.adoc#post-/v1/clusters[`POST /v1/clusters`] request. Edit `cluster_configuration` in the request body with a key-value pair for `custom_properties`. | ||
|
|
||
| * Update a cluster by making a xref:api:ROOT:cloud-controlplane-api.adoc#patch-/v1/clusters/-cluster.id-[`PATCH /v1/clusters/{cluster.id}`] request, passing the cluster ID as a parameter. Include the properties to update in the request body. | ||
|
|
||
| For a complete list of the cluster configuration properties you can edit in Redpanda Cloud, see xref:reference:properties/cluster-properties.adoc[Cluster Configuration Properties]. | ||
|
|
||
| NOTE: Some properties require a cluster restart for updates to take effect. This triggers a xref:manage:api/cloud-byoc-controlplane-api.adoc#lro[long-running operation] that can take several minutes to complete. | ||
|
|
||
| == Suggested reading | ||
|
|
||
| * xref:manage:api/cloud-api-overview.adoc[Redpanda Cloud API Overview] | ||
| * xref:manage:api/cloud-api-quickstart.adoc[Redpanda Cloud API Quickstart] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = Cluster Maintenance | ||
| :description: Learn about cluster maintenance and configuration properties. | ||
| :page-layout: index | ||
| :page-categories: Management |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| = Mountable Topics | ||
| :description: Safely attach and detach Tiered Storage topics to and from a cluster. | ||
|
|
||
| For topics with Tiered Storage enabled, you can unmount a topic to safely detach it from a cluster and keep the topic data in the cluster's object storage bucket or container. You can remount the detached topic to the origin cluster, allowing you to hibernate a topic and free up system resources taken up by the topic. | ||
|
|
||
| include::24.3@ROOT:manage:partial$mountable-topics.adoc[] | ||
| include::ROOT:manage:partial$mountable-topics.adoc[] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| = Edit Topic Configuration | ||
| :page-aliases: manage:console/edit-topic-configuration.adoc | ||
| :description: Use Redpanda Cloud to edit the configuration of existing topics in a cluster. | ||
|
|
||
| include::ROOT:manage:console/edit-topic-configuration.adoc[tag=single-source] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| = Programmable Push Filters | ||
| :page-aliases: console:features/programmable-push-filters.adoc, reference:console/programmable-push-filters.adoc | ||
| :description: Learn how to filter Kafka records in Redpanda Cloud based on your provided JavaScript code. | ||
|
|
||
| include::ROOT:reference:console/programmable-push-filters.adoc[tag=single-source] | ||
JakeSCahill marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| = Deserialization | ||
| :page-aliases: console:features/record-deserialization.adoc, manage:console/protobuf.adoc, reference:console/record-deserialization.adoc | ||
| :description: Learn how Redpanda Cloud deserializes messages. | ||
|
|
||
| include::ROOT:reference:console/record-deserialization.adoc[tag=single-source] | ||
JakeSCahill marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| = Use Schema Registry | ||
| :page-categories: Management, Schema Registry | ||
| :page-aliases: deploy:deployment-option/cloud/schema-reg-cloud.adoc | ||
| :description: Perform common Schema Registry management operations in Redpanda Cloud. | ||
|
|
||
| include::ROOT:manage:schema-reg/schema-reg-ui.adoc[tag=single-source] | ||
JakeSCahill marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| = Golang SDK for Data Transforms | ||
| :description: Work with data transform APIs in Redpanda using Go. | ||
| :page-categories: Development, Stream Processing, Data Transforms | ||
|
|
||
| include::ROOT:reference:data-transforms/golang-sdk.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| = JavaScript SDK for Data Transforms | ||
| :page-layout: index | ||
| :description: This page provides a list of API packages available in the JavaScript SDK for data transforms. Explore the functionalities and methods offered by each package to implement data transforms in your applications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = JavaScript Schema Registry API for Data Transforms | ||
| :description: Work with Schema Registry in data transforms using JavaScript. | ||
|
|
||
| include::ROOT:reference:data-transforms/js/js-sdk-sr.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = JavaScript API for Data Transforms | ||
| :description: Work with data transforms using JavaScript. | ||
|
|
||
| include::ROOT:reference:data-transforms/js/js-sdk.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| = Rust SDK for Data Transforms | ||
| :description: Work with data transforms using Rust. | ||
|
|
||
| include::ROOT:reference:data-transforms/rust-sdk.adoc[tag=single-source] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| = Data Transforms SDKs | ||
| :description: This page provides a link to all SDK reference docs for data transforms. | ||
| :page-layout: index |
13 changes: 13 additions & 0 deletions
13
modules/reference/pages/properties/cluster-properties.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| = Cluster Configuration Properties | ||
| :page-toclevels: 3 | ||
| :description: Reference of cluster configuration properties. | ||
|
|
||
| Cluster configuration properties are the same for all brokers in a cluster, and are set at the cluster level. | ||
|
|
||
| For information on how to edit cluster properties, see xref:manage:cluster-maintenance/config-cluster.adoc[]. | ||
|
|
||
| NOTE: Some properties require a cluster restart for updates to take effect. This triggers a xref:manage:api/cloud-byoc-controlplane-api.adoc#lro[long-running operation] that can take several minutes to complete. | ||
|
|
||
| == Cluster configuration | ||
|
|
||
| include::ROOT:reference:properties/cluster-properties.adoc[tags=audit_enabled;audit_excluded_principals;audit_excluded_topics;data_transforms_enabled;data_transforms_logging_line_max_bytes;iceberg_catalog_type;iceberg_delete;iceberg_enabled;iceberg_rest_catalog_client_id;iceberg_rest_catalog_client_secret;iceberg_rest_catalog_token;iceberg_rest_catalog_authentication_mode;iceberg_rest_catalog_endpoint;iceberg_rest_catalog_oauth2_server_uri;iceberg_rest_catalog_prefix;iceberg_rest_catalog_request_timeout_ms;iceberg_default_partition_spec;iceberg_invalid_record_action;iceberg_target_lag_ms;iceberg_rest_catalog_trust;iceberg_rest_catalog_crl] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| = Properties | ||
| :page-layout: index | ||
| :description: Learn about the Redpanda properties you can configure. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.