adding new healthoverview with mainenance status #86
+36
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextreichler
force-pushed
the
add-maintenance-status-cluster-overview
branch
4 times, most recently
from
8fd57e6 to
e3d5668
Compare
alextreichler
force-pushed
the
add-maintenance-status-cluster-overview
branch
from
e3d5668 to
e4b6809
Compare
Contributor
Author
|
When I originally created this PR the lint checker was telling me to update tenv -> usetesting. When I did, I get some new lint errors from the testing file. Should I fix those or leave tenv in the .gol... file? |
Contributor
|
Why don't you call the Broker func in rpk itself? Wonder if there is a benefit to do it in rpadmin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
rpk cluster health- it would be useful to see if any nodes are in maintenance mode. This newGetHealthOverviewWithMaintenancemethod will include nodes that are in maintenance mode, so it can be displayed when callingrpk cluster health