Skip to content

Conversation

@peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Nov 27, 2025

The main intent of this PR is allow this internal improvement:

https://github.com/elastic/go-elasticsearch/blob/main/CHANGELOG.md#typed-api-1

This release introduces a new MethodAPI used by the TypedClient which makes the client friendlier for dead code elimination. Reducing the size of the client when only a subset of the APIs are used. The old API structure remains available for backward compatibility, but it is now deprecated.

to use it, we can just change the yaml tag and use the output elasticsearch_v9, should be backward compatible with the v8 tag

however, since we may keep elasticsearch v8 and v9 for a while, we may not benefit immediately from the dead code elimination but the main development today is on v9, it support earlier versions of go and I think we should consider add support on it.

since both codes are very similar, I did not try create like a "base" package to reuse the logic, but I can do if needed (or in another PR)

Regards

@peczenyj
Copy link
Contributor Author

No news :/

@mmatczuk mmatczuk force-pushed the add-support-to-elasticsearch/v9 branch from 75092aa to 6d8a50d Compare December 23, 2025 12:13
@mmatczuk
Copy link
Collaborator

Rebased and updated.

@mmatczuk mmatczuk merged commit 4254821 into redpanda-data:main Dec 23, 2025
5 checks passed
@mmatczuk
Copy link
Collaborator

Thank you @peczenyj for your awesome contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants