Conversation
| run: once | ||
| silent: true | ||
| cmds: | ||
| - GOBIN={{.GOBIN}} go install github.com/google/yamlfmt/cmd/yamlfmt@latest |
There was a problem hiding this comment.
Non-reproducible dependency: @latest means every invocation can install a different version of yamlfmt, which can cause inconsistent formatting across developers and CI. The existing install-golangci-lint task pins to a specific version via a variable and uses sources for caching.
Pin yamlfmt to a specific version (e.g., @v0.16.0) using a variable (like GOLANGCI_LINT_VERSION), and add a sources block so the task is cached and only re-runs when the version changes.
There was a problem hiding this comment.
As Claude suggests, would it be better to pin it to a specific version for consistency?
There was a problem hiding this comment.
My take is that it's the legacy of the future, who would bump it and why?
|
Commits Review
|
No description provided.