fix(secrets): display plain text labels in scope dropdown trigger#2296
Merged
malinskibeniamin merged 6 commits intomasterfrom Mar 13, 2026
Merged
fix(secrets): display plain text labels in scope dropdown trigger#2296malinskibeniamin merged 6 commits intomasterfrom
malinskibeniamin merged 6 commits intomasterfrom
Conversation
Replace useStore(useApiStore, ...) with useApiStoreHook(...) in license notification components. Passing a hook as a value argument to another hook violates React Compiler rules. useApiStoreHook is an existing wrapper that encapsulates the same call pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The MultiSelect trigger was rendering JSX labels with icons, causing overflow and readability issues. Split SCOPE_OPTIONS into string labels for the trigger and JSX children with icons for the dropdown items. Fixes UX-964 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
malinskibeniamin
force-pushed
the
fix/ux-964-scope-dropdown
branch
from
f38ba4b to
dcd1de0
Compare
c-julin
approved these changes
Mar 12, 2026
Verify that MultiSelect trigger displays plain text labels like "AI Gateway" instead of raw enum numbers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace overflow-x-scroll with overflow-x-hidden on MultiSelectValue to prevent horizontal scrollbar in the trigger area. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The MultiSelect trigger displayed raw numeric enum values instead of labels when the form had pre-selected values (e.g. secrets create page). The itemCache is a non-reactive ref that only gets populated after MultiSelectItem mounts via useEffect — too late for the first render. Add an optional `items` prop to MultiSelect that seeds the cache at initialization, ensuring labels are available from the first render. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SCOPE_OPTIONSto use plain stringlabelvalues instead of JSX with iconschildren), not in the trigger tagsTest plan
Fixes UX-964
🤖 Generated with Claude Code