fix(data-table): use DropdownMenuTrigger wrapper in view options#2297
Merged
malinskibeniamin merged 9 commits intomasterfrom Mar 13, 2026
Merged
fix(data-table): use DropdownMenuTrigger wrapper in view options#2297malinskibeniamin merged 9 commits intomasterfrom
malinskibeniamin merged 9 commits intomasterfrom
Conversation
Replace useStore(useApiStore, ...) with useApiStoreHook(...) in license notification components. Passing a hook as a value argument to another hook violates React Compiler rules. useApiStoreHook is an existing wrapper that encapsulates the same call pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace raw radix DropdownMenuPrimitive.Trigger with the project's DropdownMenuTrigger wrapper in DataTableViewOptions. The raw primitive doesn't handle re-renders correctly with React Compiler. Fixes UX-967 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
malinskibeniamin
force-pushed
the
fix/ux-967-datatable-view-options
branch
from
152d1cf to
1d1ef4f
Compare
c-julin
approved these changes
Mar 12, 2026
Verify DataTableViewOptions dropdown can be reopened after toggling columns, preventing regression of the broken trigger. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The DataTable shared components (data-table.tsx, data-table-filter.tsx) were being compiled by React Compiler, which incorrectly memoized callbacks and state in DataTableFacetedFilter (Set mutation in event handlers) and other table-bound components. This broke search inputs and filter dropdowns on Knowledge Base, Secret Store, AI Agent, and Remote MCP list pages. Adding the 'use no memo' directive opts these files out of React Compiler, matching the pattern already used by the list page files. Also adds integration tests verifying the search input value updates on keystroke and can be cleared and reused. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for search input and faceted filter functionality on Knowledge Base, AI Agent, and Remote MCP list pages to prevent regressions from React Compiler memoization issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add tests for search input and faceted filter functionality on the Secret Store list page to prevent regressions from React Compiler memoization issues. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add E2E tests for the Remote MCP servers list page that run against a production build with React Compiler active. These tests verify that the search input accepts keystrokes, filters table rows, and that the status faceted filter opens and is selectable — all of which were broken when React Compiler memoized shared DataTable component callbacks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The MCP servers page isn't available in the OSS console variant, causing E2E tests to fail when the search input isn't rendered. Use test.skip() to gracefully skip when the page doesn't have the UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Delete the MCP search Playwright test (MCP page unavailable in OSS variant). Replace with comprehensive integration tests for DataTable search input, faceted filter rendering, and view options toggle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DropdownMenuPrimitive.Triggerwith the project'sDropdownMenuTriggerwrapper inDataTableViewOptionsTest plan
Fixes UX-967
🤖 Generated with Claude Code