Skip to content

fix(security): hide password change in serverless mode#2299

Merged
malinskibeniamin merged 3 commits intomasterfrom
fix/ux-963-serverless-password
Mar 13, 2026
Merged

fix(security): hide password change in serverless mode#2299
malinskibeniamin merged 3 commits intomasterfrom
fix/ux-963-serverless-password

Conversation

@malinskibeniamin
Copy link
Contributor

@malinskibeniamin malinskibeniamin commented Mar 12, 2026

Summary

  • Added isServerless() guard to password change button in user details page
  • Added isServerless() guard to password change menu item in users list
  • Added isServerless() guard to ChangePasswordModal rendering in both locations
  • UpdateUser API is not supported in serverless, so the UI should not expose this action

Test plan

  • In serverless mode: open Security → Users → click a user → verify no "Change password" button
  • In serverless mode: open Security → Users → click user menu → verify no "Change password" option
  • In non-serverless mode: verify password change still works as before

Fixes UX-963

🤖 Generated with Claude Code

@malinskibeniamin malinskibeniamin added frontend ui/ux bug Something isn't working labels Mar 12, 2026
@malinskibeniamin malinskibeniamin self-assigned this Mar 12, 2026
malinskibeniamin and others added 2 commits March 12, 2026 17:50
Replace useStore(useApiStore, ...) with useApiStoreHook(...) in license
notification components. Passing a hook as a value argument to another
hook violates React Compiler rules. useApiStoreHook is an existing
wrapper that encapsulates the same call pattern.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
UpdateUser is not supported in serverless, so hide the password
change button and modal in both user details and user list views.

Fixes UX-963

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@malinskibeniamin malinskibeniamin force-pushed the fix/ux-963-serverless-password branch from 6a2e8d6 to e1b48cf Compare March 12, 2026 17:00
Add test confirming the change password UI is not shown when
isServerless() returns true.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@malinskibeniamin malinskibeniamin merged commit 63e2333 into master Mar 13, 2026
15 checks passed
@malinskibeniamin malinskibeniamin deleted the fix/ux-963-serverless-password branch March 13, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working frontend ui/ux

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants