Skip to content

Conversation

@JakeSCahill
Copy link
Contributor

Description

We have dependencies that require Node.js 20+. We also removed the api branch when we launch Bump and we also have a new v25.1 branch that will need updates.

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@JakeSCahill JakeSCahill requested a review from a team as a code owner August 28, 2025 08:55
@netlify
Copy link

netlify bot commented Aug 28, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 6d0da0c
🔍 Latest deploy log https://app.netlify.com/projects/redpanda-docs-preview/deploys/68b07d47f1934d00084825b7
😎 Deploy Preview https://deploy-preview-1345--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 28, 2025

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbit review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

Updated the GitHub Actions workflow .github/workflows/update-extensions.yml:

  • Adjusted matrix.branch to remove "api" and add "v25.1", resulting in: [main, 'v25.1', 'v/24.3', 'v/24.2', 'v/24.1'].
  • Bumped Node.js version used in the workflow from 18 to 20.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • asimms41
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch JakeSCahill-patch-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/update-extensions.yml (1)

27-29: Leading comma in secret-ids may break secrets retrieval.

The first entry is empty. Remove the leading comma to avoid action failures. Ensure the secret value is JSON with key ACTIONS_BOT_TOKEN since parse-json-secrets: true is set.

Apply this diff:

           secret-ids: |
-            ,sdlc/prod/github/actions_bot_token
+            sdlc/prod/github/actions_bot_token
🧹 Nitpick comments (1)
.github/workflows/update-extensions.yml (1)

40-40: Target latest Node 20.x and enable npm caching.

Use semver-friendly pinning, ensure latest patch is used, and cache npm to speed runs. Consider npm ci for reproducibility.

Apply this diff:

       - name: Set up Node.js
         uses: actions/setup-node@v4
         with:
-          node-version: '20'
+          node-version: '20.x'
+          check-latest: true
+          cache: 'npm'

Optionally make installs deterministic:

-      - name: Install dependencies
-        run: npm install
+      - name: Install dependencies
+        run: npm ci
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between da0c087 and 17809cb.

📒 Files selected for processing (1)
  • .github/workflows/update-extensions.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules - redpanda-docs-preview
  • GitHub Check: Header rules - redpanda-docs-preview
  • GitHub Check: Pages changed - redpanda-docs-preview

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@JakeSCahill JakeSCahill merged commit 0bf9d82 into main Aug 28, 2025
3 checks passed
@JakeSCahill JakeSCahill deleted the JakeSCahill-patch-5 branch August 28, 2025 16:01
@coderabbitai coderabbitai bot mentioned this pull request Aug 29, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants