-
Notifications
You must be signed in to change notification settings - Fork 47
Fix auto-update extension #1345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughUpdated the GitHub Actions workflow .github/workflows/update-extensions.yml:
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/update-extensions.yml (1)
27-29: Leading comma in secret-ids may break secrets retrieval.The first entry is empty. Remove the leading comma to avoid action failures. Ensure the secret value is JSON with key
ACTIONS_BOT_TOKENsinceparse-json-secrets: trueis set.Apply this diff:
secret-ids: | - ,sdlc/prod/github/actions_bot_token + sdlc/prod/github/actions_bot_token
🧹 Nitpick comments (1)
.github/workflows/update-extensions.yml (1)
40-40: Target latest Node 20.x and enable npm caching.Use semver-friendly pinning, ensure latest patch is used, and cache npm to speed runs. Consider
npm cifor reproducibility.Apply this diff:
- name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: '20' + node-version: '20.x' + check-latest: true + cache: 'npm'Optionally make installs deterministic:
- - name: Install dependencies - run: npm install + - name: Install dependencies + run: npm ci
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/update-extensions.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - redpanda-docs-preview
- GitHub Check: Header rules - redpanda-docs-preview
- GitHub Check: Pages changed - redpanda-docs-preview
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Description
We have dependencies that require Node.js 20+. We also removed the
apibranch when we launch Bump and we also have a new v25.1 branch that will need updates.Page previews
Checks