-
Notifications
You must be signed in to change notification settings - Fork 47
update shadowing config #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update shadowing config #1486
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis pull request updates the disaster recovery shadowing configuration documentation by restructuring and renaming configuration sections. Changes include nesting fields like Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
modules/manage/pages/disaster-recovery/shadowing/setup.adoc (1)
199-206: Pattern type documentation is incomplete; examples usePREFIXEDwhich isn't documented.The "Filter types and patterns" section documents
LITERALandPREFIX, but examples at lines 298 and 578 usepattern_type: PREFIXED. According to the AI summary, pattern types were renamed from PREFIX to PREFIXED. The documentation needs to reflect this change to match the examples and avoid user confusion.Update the documentation to include the renamed pattern type:
* **Pattern type**: Determines how names are matched - `LITERAL`: Matches names exactly (including the special wildcard `*` to match all items) - - `PREFIX`: Matches names that start with the specified string + - `PREFIXED`: Matches names that start with the specified stringThen audit all examples to ensure consistency—replace
pattern_type: PREFIXwithpattern_type: PREFIXEDin examples that use prefix matching.
🧹 Nitpick comments (1)
modules/manage/pages/disaster-recovery/shadowing/setup.adoc (1)
347-365: Clarify the structure forstart_at_timestampexamples.The timestamp example at line 364 lacks the nested block structure shown for
start_at_earliestandstart_at_latest. Consider adding a clarifying comment or reformatting for consistency:Or to start from a specific timestamp: [,yaml] ---- topic_metadata_sync_options: - start_at_timestamp: 2024-01-01T00:00:00Z + start_at_timestamp: + timestamp: 2024-01-01T00:00:00Z ----Verify the actual YAML schema to ensure the structure shown is correct. If
start_at_timestampis a direct string value (not nested), the current format is correct but should be clarified in a note.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
modules/manage/pages/disaster-recovery/shadowing/setup.adoc(10 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-16T13:51:26.524Z
Learnt from: JakeSCahill
Repo: redpanda-data/docs PR: 1358
File: modules/reference/partials/rpk-cloud/rpk-cloud-mcp-proxy.adoc:57-63
Timestamp: 2025-09-16T13:51:26.524Z
Learning: rpk config file search paths are platform-specific: macOS uses "~/Library/Application Support/rpk/rpk.yaml" while Linux uses "/var/lib/redpanda/.config/rpk/rpk.yaml". The documentation should account for platform differences rather than assuming Linux-only paths.
Applied to files:
modules/manage/pages/disaster-recovery/shadowing/setup.adoc
🔇 Additional comments (1)
modules/manage/pages/disaster-recovery/shadowing/setup.adoc (1)
70-84: All commands verified as valid.The
--print-templateflag exists and is properly documented in the official RPK reference. The commands shown in the TIP section match the documented examples exactly, and the descriptions accurately reflect the flag behavior. No changes needed.
Description
Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Page previews
Checks