-
Notifications
You must be signed in to change notification settings - Fork 47
add shadowing metrics #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add shadowing metrics #1496
Changes from 28 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
0228148
DOC-1667 Document Shadow Link in Cloud
micheleRP bffbfea
single source rpk shadow
micheleRP d3db493
conditionalize parts for Cloud
micheleRP 05bac83
add description for rpk shadow (for index page)
micheleRP d3e108c
minor edits
micheleRP 9c5e166
fix headings
micheleRP 7a6ffad
update conditionalizing
micheleRP 781937a
move conceptual sections from setup into overview
micheleRP 6e8ac75
rearranging setup
micheleRP 582e395
byoc/dedicated only
micheleRP 614e5c5
conditionalizing
micheleRP 043e166
change Configure Failover to Failover
micheleRP 763f4da
incorporate Trevor's review feedback
micheleRP 6c97ab7
minor edit
micheleRP 841a5a6
move tip next to sample config file
micheleRP d8e0bbc
remove disaster readiness checklist from overview
micheleRP f48eefd
remove duplicated content
micheleRP 1d9c180
incorporate Simon's feedback
micheleRP aea6e82
Update modules/manage/pages/disaster-recovery/shadowing/setup.adoc
micheleRP 1905b94
add shadowing metrics
paulohtb6 a90f4de
reintroduce shadowing metrics
paulohtb6 12b3ce6
Merge branch 'main' into add-metrics
paulohtb6 611025a
add whats new
paulohtb6 12f1ec5
code review
paulohtb6 10365a6
fix
paulohtb6 974cec9
Update local-antora-playbook.yml
paulohtb6 3bb252d
Apply suggestion from @micheleRP
micheleRP ccff0dc
Apply suggestion from @micheleRP
micheleRP c372064
Apply suggestion from @micheleRP
micheleRP dec1ea4
incorporate feedback from review
micheleRP bca7216
Merge branch 'main' into add-metrics
paulohtb6 d37426b
Fix
paulohtb6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure
throughputis a good word here. Throughput means rate, while this is the total records fetched/written.When it is next to the explanation, it's good. When it's alone, it might give the wrong impression of what this metric is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you, fixed!