-
Notifications
You must be signed in to change notification settings - Fork 47
DOC-1855 SR support for SASL/PLAIN in SM #1510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR updates the local Antora playbook to source cloud documentation from a feature branch dedicated to documenting the shadowing disaster recovery feature. It also introduces SASL/PLAIN authentication configuration to the disaster recovery setup documentation, with conditional blocks ensuring this configuration only appears in non-cloud environments while preserving existing SASL/SCRAM, TLS, and mTLS options across multiple authentication sections. Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
Comment |
rpdevmp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This pull request adds support for SASL/PLAIN authentication alongside existing methods for Self-Managed.
plain_configuration) in theclient_optionssections, alongside existing SASL/SCRAM examples, and ensure these are documented for non-cloud environments. [1] [2]cloud-docsinlocal-antora-playbook.ymlfrommaintoDOC-1621-Document-Cloud-Feature-Shadowing-Disaster-Recovery-Enterpriseto show preview docs in Cloud don't contain this.Resolves https://redpandadata.atlassian.net/browse/DOC-1855
Review deadline:
Page previews
Configure Shadowing: SM (search for PLAIN)
Configure Shadowing: Cloud (search for PLAIN)
Checks