-
Notifications
You must be signed in to change notification settings - Fork 47
updates for UI #1511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates for UI #1511
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThis PR adds Cloud UI documentation to the Redpanda disaster recovery shadowing feature across four documentation files. Changes include introducing Cloud UI placeholder blocks with deferred content in failover-runbook.adoc, adding step-by-step Cloud UI instructions for failover procedures in failover.adoc, introducing Cloud UI navigation guidance with non-executable phrasing in monitor.adoc, and adding Cloud UI secret creation and shadow link creation/editing flows alongside existing rpk and API documentation in setup.adoc. No functional code changes or exported entity modifications are introduced. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10–15 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
modules/manage/pages/disaster-recovery/shadowing/failover-runbook.adoc(7 hunks)modules/manage/pages/disaster-recovery/shadowing/failover.adoc(4 hunks)modules/manage/pages/disaster-recovery/shadowing/monitor.adoc(7 hunks)modules/manage/pages/disaster-recovery/shadowing/setup.adoc(3 hunks)
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-11-25T09:42:15.235Z
Learnt from: CR
Repo: redpanda-data/docs PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-25T09:42:15.235Z
Learning: Applies to docs-data/property-overrides.json : In property descriptions, never add cloud-specific conditional blocks or notes about BYOC, Dedicated, or read-only status
Applied to files:
modules/manage/pages/disaster-recovery/shadowing/failover-runbook.adoc
📚 Learning: 2025-05-07T01:06:00.937Z
Learnt from: kbatuigas
Repo: redpanda-data/docs PR: 1113
File: modules/manage/partials/iceberg/use-iceberg-catalogs.adoc:100-107
Timestamp: 2025-05-07T01:06:00.937Z
Learning: In AsciiDoc documentation for Redpanda, the syntax `+` and `--` around content blocks within a `[tabs]` section are valid AsciiDoc formatting elements for tabbed content. The `+` after a tab name (like `rpk::`) indicates that the following block belongs to that tab, and the `--` markers enclose the content for that tab. These are not diff artifacts and should not be removed.
Applied to files:
modules/manage/pages/disaster-recovery/shadowing/failover-runbook.adoc
📚 Learning: 2025-08-25T21:00:26.626Z
Learnt from: micheleRP
Repo: redpanda-data/docs PR: 1334
File: modules/manage/partials/rbac-dp.adoc:93-98
Timestamp: 2025-08-25T21:00:26.626Z
Learning: In cloud documentation (env-cloud), Security is at the top level navigation, so ACL references should use `security:authorization/rbac/acl.adoc`. In self-managed documentation, Security is nested under Manage, so ACL references use `manage:security/authorization/acl.adoc`. The different xref paths in conditional blocks reflect these different navigation structures.
Applied to files:
modules/manage/pages/disaster-recovery/shadowing/monitor.adocmodules/manage/pages/disaster-recovery/shadowing/setup.adoc
🔇 Additional comments (5)
modules/manage/pages/disaster-recovery/shadowing/setup.adoc (5)
107-114: Clarify the{ui}placeholder.Line 109 uses
{ui}as a placeholder attribute. Verify this resolves correctly in the documentation build system. If{ui}is not a standard AsciiDoc attribute, replace it with the literal text "the Cloud UI" or "Cloud UI" for clarity.-Not all filters are available in {ui}. For full filter configuration, use `rpk` or the API. +Not all filters are available in the Cloud UI. For full filter configuration, use `rpk` or the API.
270-290: Excellent tabbed secret creation interface.The three-option tabs (Cloud UI, rpk, Data Plane API) provide clear, parallel paths for users to choose their preferred method. Each option is concise and actionable.
296-306: Well-structured Cloud UI shadow link creation steps.The five numbered steps are clear and comprehensive. The note about advanced settings and filter limitations (line 304) correctly directs users to rpk/API for full configuration. One minor suggestion: line 302 could explicitly mention "in the shadow cluster" to clarify which cluster context the user is operating in, though the earlier context makes this clear.
314-382: Control Plane API payload is well-documented.The curl example includes detailed comments explaining each field, with helpful placeholder examples. The post-command explanation of replaceable values (lines 369–377) is thorough and aids users in adapting the request to their environment.
698-706: Cloud UI shadow link editing instructions are clear and parallel.The edit flow mirrors the creation flow appropriately, providing five steps covering navigation, selection, modification, and confirmation. The reference to "Secrets Store" (line 276) and note about needing all ACLs (line 275) are helpful context additions.
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fd64cb7 to
9ecbab9
Compare
20ef000 to
729c8db
Compare
... And if using mTLS, you must also create a secret to hold the key of the client certificate for the client to authenticate. That secret should be referenced in |
|
It'd be nice if in the UI docs we can point to the UI links. For example, for secrets https://cloud.redpanda.com/clusters/<SHADOW_CLUSTER_ID>/secrets |
# Conflicts: # modules/manage/pages/disaster-recovery/shadowing/monitor.adoc
# Conflicts: # modules/manage/pages/disaster-recovery/shadowing/setup.adoc
15f676f to
3be5055
Compare
| . Click *Create shadow link*. | ||
| . Enter a unique name for the shadow link. The name must start and end with lowercase alphanumeric characters, hyphens allowed. | ||
| . Select the source cluster from which data will be replicated. You can select an existing Redpanda Cloud cluster, or you can enter a bootstrap server URL to connect to any Kafka-compatible cluster. For an existing Redpanda Cloud cluster, you select the specific cluster on the next page. | ||
| . Enter the authorization and authentication details for the source cluster, including the user and the name of the secret containing the password created in the previous step. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this say "for the shadow cluster"? Or, "enter the... details from the source cluster"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to from





Description
This pull request adds Cloud UI workflows to the disaster recovery shadowing guides. It introduces Cloud UI instructions alongside existing
rpkand API steps using tabs, plus some general improvements to wording and organization.rpkor the API for full configuration insetup.adoc.rpk, and API methods, and added step-by-step Cloud UI guidance for shadow link creation and editing. [1] [2]Page previews
Configure
Monitor
Failover
Failover Runbook
Checks