-
Notifications
You must be signed in to change notification settings - Fork 47
tidy instructions for shadowing #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5af52e8
tiddy instructions for shadowing
paulohtb6 d17d5d8
fix
paulohtb6 4cddbca
fix header
paulohtb6 42f600b
reintroduce cloud if
paulohtb6 6c50797
remove link on clcoud
paulohtb6 cf8ed3e
fix
paulohtb6 8e53908
Update modules/manage/partials/shadowing/shadow-link-prerequisites.adoc
paulohtb6 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,12 @@ | ||
| // tag::cluster-property[] | ||
| Both source and shadow clusters must have the xref:reference:properties/cluster-properties.adoc#enable_shadow_linking[`enable_shadow_linking`] cluster property set to `true`. | ||
| The shadow cluster must have the xref:reference:properties/cluster-properties.adoc#enable_shadow_linking[`enable_shadow_linking`] cluster property set to `true`. | ||
|
|
||
| ifdef::env-cloud[] | ||
| [NOTE] | ||
| ==== | ||
| Starting with Redpanda v25.3, this cluster property is enabled by default on new Redpanda Cloud clusters. For existing clusters on versions earlier than v25.3, you must enable this property manually. See xref:manage:cluster-maintenance/config-cluster.adoc[]. | ||
| ==== | ||
| endif::[] | ||
|
|
||
| ifdef::env-kubernetes[] | ||
| [tabs] | ||
|
|
@@ -39,6 +46,7 @@ config: | |
| endif::[] | ||
|
|
||
| ifndef::env-kubernetes[] | ||
| ifndef::env-cloud[] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This block is still somehow displayed on the Cloud version on the page: https://deploy-preview-1549--redpanda-docs-preview.netlify.app/redpanda-cloud/manage/disaster-recovery/shadowing/setup/#cluster-configuration I wonder if it's the double ifndefs. |
||
| To enable this property, run: | ||
| [,bash] | ||
| ---- | ||
|
|
@@ -50,8 +58,10 @@ rpk cluster config set enable_shadow_linking true | |
| This cluster property must be configured using `rpk` or the Admin API v1 before you can create shadow links through any interface. | ||
| ==== | ||
|
|
||
|
|
||
| To learn more about configuring cluster properties, see xref:manage:cluster-maintenance/cluster-property-configuration.adoc[]. | ||
| endif::[] | ||
| endif::[] | ||
| // end::cluster-property[] | ||
|
|
||
| // tag::replication-permissions[] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks all right in Self-managed (including Kubernetes) but not really in Cloud? Unless I'm looking at the wrong preview. Could you please double check?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed one if for cloud. Should be fine now. Thanks for spotting that!