Skip to content

Doc-476 - Backfill partitioning update #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Feediver1 merged 20 commits into from
Nov 15, 2024
Merged

Doc-476 - Backfill partitioning update #842

Feediver1 merged 20 commits into from
Nov 15, 2024

Conversation

@Feediver1
Copy link
Contributor

@Feediver1 Feediver1 commented Nov 8, 2024 •
edited
Loading

Description

Resolves (https://redpandadata.atlassian.net/browse/DOC-476)
Review deadline: EOB Monday, Nov 11

Preview

Page previews

Checks

  • [x ] New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@Feediver1 Feediver1 requested a review from a team as a code owner November 8, 2024 19:33
@netlify
Copy link

netlify bot commented Nov 8, 2024 •
edited
Loading

✅ Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 574dfeb
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/6737ac43d6c7d700087a901b
😎 Deploy Preview https://deploy-preview-842--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mattschumpert
mattschumpert approved these changes Nov 12, 2024
View reviewed changes
@Feediver1 Feediver1 requested a review from micheleRP November 12, 2024 20:10
JakeSCahill
JakeSCahill reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@JakeSCahill JakeSCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions for terminology

Feediver1 and others added 15 commits November 14, 2024 16:46
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
4753436 
…covery.adoc
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
3c07afc 
…covery.adoc
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
2e6e0da 
…covery.adoc
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
407526c 
…covery.adoc
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
dd77f56 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
699f499 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
6cbc622 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
84d85bb 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
3822d47 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 @micheleRP
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
da85fae 
…covery.adoc

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1
Apply suggestions from code review
56f3839 
Matt's feedback on PR
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
3b13fef 
…covery.adoc
@Feediver1
Update modules/manage/pages/cluster-maintenance/nodewise-partition-re…
01252b3 
…covery.adoc
@Feediver1 @JakeSCahill
Apply suggestions from code review doc feedback
846f4dd 
Co-authored-by: Jake Cahill <[email protected]>
@Feediver1
Apply suggestions from code review
83fb215 
Feedback from Michal
@JakeSCahill JakeSCahill self-requested a review November 15, 2024 17:28
JakeSCahill
JakeSCahill approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@JakeSCahill JakeSCahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

micheleRP
micheleRP approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm: I just added a few more suggestions to the original content to align with our standards while we're editing this file.

@Feediver1 @micheleRP
Apply suggestions from code review
574dfeb 
edits from doc review

Co-authored-by: Michele Cyran <[email protected]>
@Feediver1 Feediver1 merged commit ddbe343 into v-WIP/24.3 Nov 15, 2024
5 checks passed
@Feediver1 Feediver1 deleted the Doc-476 branch November 15, 2024 20:28
Deflaimun pushed a commit that referenced this pull request Nov 19, 2024
@Feediver1 @micheleRP
@JakeSCahill @Deflaimun
Doc-476 - Backfill partitioning update (#842)
2e4c81c 
Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Jake Cahill <[email protected]>
Deflaimun pushed a commit that referenced this pull request Dec 2, 2024
@Feediver1 @micheleRP
@JakeSCahill @Deflaimun
Doc-476 - Backfill partitioning update (#842)
26e9304 
Co-authored-by: Michele Cyran <[email protected]>
Co-authored-by: Jake Cahill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmaslankaprv mmaslankaprv mmaslankaprv left review comments

@JakeSCahill JakeSCahill JakeSCahill approved these changes

@mattschumpert mattschumpert mattschumpert approved these changes

@micheleRP micheleRP micheleRP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Feediver1 @mmaslankaprv @JakeSCahill @mattschumpert @micheleRP