charts/console: Remove unrecognized flags from wget#1685
Merged
RafalKorepta merged 1 commit intomainfrom May 8, 2025
Merged
Conversation
4ebecda to
9145a03
Compare
andrewstucki
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that wget inside busybox is not the same as the one that I read the man page. I was surprised that test in PR that cut console helm chart v3.1.0 #1684 did not complain about
unrecognized flags. The proof that the fix works is the successful pipeline execution in #1683. I deliberately replaced in the Github Release v3.1.0 the artifactconsole-v3.1.0.tgz, because it is the place of reference from our index.yaml file.