provide client certs to servicemonitor CRDs#687
provide client certs to servicemonitor CRDs#687gugu wants to merge 3 commits intoredpanda-data:mainfrom
Conversation
gugu
requested review from
RafalKorepta,
alejandroEsc and
joejulian
as code owners
|
|
alejandroEsc
left a comment
alejandroEsc
left a comment
There was a problem hiding this comment.
Thank you for your contribution, and i have to say great suggestion for an improvement!
| @@ -38,10 +38,22 @@ spec: | |||
| scheme: https | |||
| tlsConfig: | |||
| insecureSkipVerify: true | |||
There was a problem hiding this comment.
Should we skip this if we are applying the certs?
There was a problem hiding this comment.
It makes HTTPS request to IP address (without hostname) and check SANs for the certificate (and it does not match)
| scheme: https | ||
| tlsConfig: | ||
| insecureSkipVerify: true | ||
| ca: |
There was a problem hiding this comment.
Only if CA is enabled right? That is an option in the certs stanza of the values file.
| insecureSkipVerify: true | ||
| ca: | ||
| secret: | ||
| name: {{ template "redpanda.fullname" $ }}-default-cert |
There was a problem hiding this comment.
This is the default name in most cases, but not necessarily, we should check to see if a secret is being provided instead also.
3 participants
No description provided.