Conversation
|
|
RafalKorepta
left a comment
There was a problem hiding this comment.
LGTM, please sign CLA
alejandroEsc
left a comment
There was a problem hiding this comment.
one question, non blocking.
| port: {{ $listener.port }} | ||
| {{- end }} | ||
| {{- end }} | ||
| admin_api_tls: |
There was a problem hiding this comment.
To be clear, nothing will break if this is empty nor if this is left out?
There was a problem hiding this comment.
It seems this is the case, which is surprising to me as it could result in an empty section in the yaml. I'm not sure why disabling TLS works without the change in this PR.
|
@ivotron Could you help in the problem of CLA boot confusion? |
|
that's a race we've seen elsewhere. fine to ignore since we have that green one |
a9a8cff to
4101cf8
Compare

Small change to move the start of the two TLS sections
admin_api_tlsandkafka_api_tlsinto their associated if statement.