Random data produce #64
Conversation
Signed-off-by: Noah Watkins <[email protected]>
this is useful to avoid needing to refactor other users of the generate interface like kgo-repeater Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
|
Please see my commit message here about why I reverted use of We should open a PR in |
Signed-off-by: Noah Watkins <[email protected]>
Signed-off-by: Noah Watkins <[email protected]>
|
made it faster and started ci run redpanda-data/redpanda#25704 |
WillemKauf
left a comment
WillemKauf
left a comment
There was a problem hiding this comment.
please merge after CI finishes in redpanda-data/redpanda#25704
| func Benchmark_old_random_payload1(b *testing.B) { benchmark_old_random_payload(10, b) } | ||
| func Benchmark_old_random_payload2(b *testing.B) { benchmark_old_random_payload(100, b) } | ||
| func Benchmark_old_random_payload3(b *testing.B) { benchmark_old_random_payload(1000, b) } | ||
| func Benchmark_old_random_payload10(b *testing.B) { benchmark_old_random_payload(10000, b) } |
There was a problem hiding this comment.
nit: i know this is copypasta from elsewhere but if we're going to check this in we might as well make the Benchmark function names sensible (10,20,40 should be 4, 5, 6 to indicate number of zeros)
| data := make([]byte, size) | ||
| for i := range data { | ||
| // printable ascii range | ||
| data[i] = byte(rand.Intn(126+1-32) + 32) |
There was a problem hiding this comment.
any good way to reuse the definition in valueGenerator? not a huge deal if not
There was a problem hiding this comment.
i dunno. just choosing my battles
Signed-off-by: Noah Watkins <[email protected]>
2 participants
Currently unless we are in latest offset verifier mode, we only append zeros which is very compressible. Too compressible.