Add GA #144

StephanDollberg · 2025-12-02T10:50:24Z

Adds a github actions job to upload the minimal tar.gz to our S3 bucket
such that we can use it in bazel.

travisdowns · 2025-12-02T12:29:06Z

.github/workflows/upload-to-s3.yml

+    branches: [main]
+  pull_request:
+    branches:
+      - main


Is this right? Will this upload the artifact from PRs before they are merged?

(I assume you don't want to do that)

No I don't, this is all still WIP testing phase. I need devprod to create some credentials first.

Adds a github actions job to build and upload the minimal tar.gz to our S3 bucket such that we can use it in bazel. On PRs only build.

travisdowns · 2025-12-11T13:44:34Z

.github/workflows/ci.yml

+    branches: [main]
+  pull_request:
+    branches:
+      - main


Trying out all the YAML list variations, huh?

LOL I don't understand yaml to this day.

Isn't this one the normal one?

This is the most common one I think but right above for identical branches you have the other one.

just to clarify:

push.branches. triggers it whenever a commit gets pushed to the given list of branches. so this would trigger when a PR is merged to the main branch, and also if someone pushed directly to it (though we disallow that via branch protection rules)

pull_request.branches. triggers the job when a PR against the main branch is opened, or when new commits to an existing PR's branch are pushed

workflow_dispatch. allows the workflow to be triggered by other workflows or manually when a person runs it from the web UI.

so your goal is to have this workflow run in any of the above scenarios?

Yes the first two is what we want.

The last I don't really mind but is good to have I guess.

travisdowns · 2025-12-11T13:44:56Z

.github/workflows/ci.yml

+on:
+  push:
+    branches: [main]
+  pull_request:


Cool, so we get build on PRs too, nice!

travisdowns · 2025-12-11T13:45:39Z

.github/workflows/ci.yml

+        run: mvn clean compile package -DskipTests
+
+      - name: Upload to S3 bucket
+        if: github.event_name == 'push'


So this works on a GH "merge PR" click, right?

That's what I expect yes.

so this will ONLY upload when a PR is merged. that's what you want, right?

Yes exactly.

travisdowns

Looks good to me, but let's get devprod eyes on it too.

ivotron · 2025-12-16T22:22:12Z

lgtm

StephanDollberg requested a review from a team as a code owner December 2, 2025 10:50

StephanDollberg requested review from travisdowns and removed request for a team December 2, 2025 10:50

StephanDollberg force-pushed the stephan/ga branch 5 times, most recently from c018ab7 to 6230304 Compare December 2, 2025 11:01

travisdowns reviewed Dec 2, 2025

View reviewed changes

StephanDollberg force-pushed the stephan/ga branch 3 times, most recently from b67b098 to 901ad4f Compare December 11, 2025 10:21

Add GA

ce2a742

Adds a github actions job to build and upload the minimal tar.gz to our S3 bucket such that we can use it in bazel. On PRs only build.

StephanDollberg force-pushed the stephan/ga branch from 901ad4f to ce2a742 Compare December 11, 2025 10:26

StephanDollberg requested a review from travisdowns December 11, 2025 10:27

travisdowns reviewed Dec 11, 2025

View reviewed changes

.github/workflows/ci.yml

on:

push:

branches: [main]

pull_request:

Copy link

Member

travisdowns Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so we get build on PRs too, nice!

travisdowns reviewed Dec 11, 2025

View reviewed changes

travisdowns approved these changes Dec 11, 2025

View reviewed changes

ivotron approved these changes Dec 16, 2025

View reviewed changes

StephanDollberg merged commit 3b204f6 into main Dec 17, 2025
1 check passed

Add GA #144

Add GA #144

Uh oh!

Conversation

StephanDollberg commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

travisdowns Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivotron Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

travisdowns left a comment

Choose a reason for hiding this comment

Uh oh!

ivotron commented Dec 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

StephanDollberg commented Dec 2, 2025 •

edited

Loading

travisdowns Dec 16, 2025 •

edited

Loading

ivotron Dec 16, 2025 •

edited

Loading