Fix up configwatcher symlink re-creation #1076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewstucki
requested review from
RafalKorepta,
chrisseto and
gene-redpanda
as code owners
chrisseto
approved these changes
Sep 10, 2025
Contributor
|
Mind adding a fix change log entry before merging? |
RafalKorepta
approved these changes
Sep 11, 2025
Contributor
RafalKorepta
left a comment
RafalKorepta
left a comment
There was a problem hiding this comment.
LGTM, it would be nice to add test.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Fix up configwatcher symlink re-creation * Add changelog entries (cherry picked from commit da59ea5)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2025
* Fix up configwatcher symlink re-creation * Add changelog entries (cherry picked from commit da59ea5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
andrewstucki
added a commit
that referenced
this pull request
Sep 11, 2025
* Fix up configwatcher symlink re-creation * Add changelog entries (cherry picked from commit da59ea5) Co-authored-by: Andrew Stucki <[email protected]>
andrewstucki
added a commit
that referenced
this pull request
Sep 11, 2025
* Fix up configwatcher symlink re-creation * Add changelog entries (cherry picked from commit da59ea5) Co-authored-by: Andrew Stucki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there appears to be a bug with the way the config-watcher syncs users. In particular, it seems like the Kubernetes mechanism for writing out a changed secret is actually re-creating a symlink in the secrets directory that points to the mounted secret. This modifies the config watcher to leverage the recreation of that symlink event to trigger user re-sync.