*: stop leaking (most) etcd procs #1090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The majority of usages of `RedpandaTestEnv` leak `etcd` and `kube-apiserver` processes. This slowly bogs down machines running tests as part of their development loop. The ideal fix would be to plumb a testing.T into it and hook into cleanup but the widespread usage makes refactoring quite tedious. This commit instead attaches a finalizer to the returned `*rest.Config` which drops the leaked procs by > 50% (~10 leaks vs ~30). The leakage will vary across runs and is made worse by test failures. Never the less this is an improvement.
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
andrewstucki
approved these changes
Sep 16, 2025
This was referenced Sep 16, 2025
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The majority of usages of
RedpandaTestEnvleaketcdandkube-apiserverprocesses. This slowly bogs down machines running tests as part of their development loop.The ideal fix would be to plumb a testing.T into it and hook into cleanup but the widespread usage makes refactoring quite tedious.
This commit instead attaches a finalizer to the returned
*rest.Configwhich drops the leaked procs by > 50% (~10 leaks vs ~30). The leakage will vary across runs and is made worse by test failures. Never the less this is an improvement.