-
Notifications
You must be signed in to change notification settings - Fork 15
Add Azure configuration options for tiered storage #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @andrewstucki |
|
FYI too, here is a list of all of the cluster configuration options related to tiered storage and azure pulled from a recent-ish schema just to validate the typing (we should really leverage the published schema to autogen some of this code): |
RafalKorepta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would rather change our documentation to points out that config.cluster is more flexible.
chrisseto
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree with @RafalKorepta.
|
@andrewstucki Should we back port to at least 25.1.x? |
(cherry picked from commit 312287a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
(cherry picked from commit 312287a) Co-authored-by: Andrew Stucki <[email protected]>
#1099 points out that we're missing the ability to set
azure_vm_instance_metadatain our rendering code/helm chart. Following our docs for configuring tiered storage (make sure you're selecting the "Azure" option), looks like we're missing a few other fields as well. It looks like these are already fields in ourRedpandaCRD, so my guess is this is mainly affecting helm chart users due to the schema validation that happens during a helm install.