Skip to content

Conversation

@andrewstucki
Copy link
Contributor

This is the alternative to #1127 in which we use expanded, duplicated feature definitions rather than the variant tags.

Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this PR include the variant and injectVariant tags in harpoon?

@andrewstucki
Copy link
Contributor Author

I'll drop the variant stuff if we want to go this direction, just let me know what we'd prefer (I kind of prefer variant as it makes it so we don't have to dup the features, but it's also a bit "magic"). The plan is to either merge this or #1127, and then close the other.

Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of the two, I like the explicitness of this one a touch a more but not having to duplicate all the tests is pretty sweet.

Both LGTM, @andrewstucki take your pick or @RafalKorepta you can be our tie breaker :D

@andrewstucki
Copy link
Contributor Author

Closing in favor of #1127

@RafalKorepta RafalKorepta deleted the as/acceptance-test-expansion branch December 12, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants