operator: move v1 nodepool tests to acceptance

.buildkite/testsuite.yml

@@ -213,49 +213,4 @@ steps:
         context: kuttl-v1
         report-slowest: 10
     soft_fail: true
-- group: Kuttl-V1-Nodepools Tests
-  key: kuttl-v1-nodepools
-  steps:
-  - agents:
-      queue: k8s-m6id12xlarge
-    command: ./ci/scripts/run-in-nix-docker.sh task ci:configure ci:test:kuttl-v1-nodepools
-    env:
-      LOG_LEVEL: trace
-      OTLP_DIR: /work/artifacts
-      OTLP_METRIC_INTERVAL: 5s
-    key: kuttl-v1-nodepools-run
-    label: Run Kuttl-V1-Nodepools Tests
-    notify:
-    - github_commit_status:
-        context: Kuttl-V1-Nodepools Tests
-    plugins:
-    - github.com/seek-oss/aws-sm-buildkite-plugin#v2.3.2:
-        json-to-env:
-        - secret-id: sdlc/prod/buildkite/github_api_token
-        - secret-id: sdlc/prod/buildkite/redpanda_sample_license
-        - secret-id: sdlc/prod/buildkite/slack_vbot_token
-    - https://[email protected]/redpanda-data/step-slack-notify-buildkite-plugin.git#main:
-        channel_name: kubernetes-tests
-        conditions:
-          branches:
-          - main
-          failed: true
-        message: ':cloud: Kuttl-V1-Nodepools Tests Job Failed'
-        slack_token_env_var_name: SLACK_VBOT_TOKEN
-    soft_fail: false
-    timeout_in_minutes: 30
-  - continue_on_failure: true
-    wait: null
-  - agents:
-      queue: pipeline-uploader
-    allow_dependency_failure: true
-    command: ""
-    key: kuttl-v1-nodepools-parse
-    label: Parse and annotate Kuttl-V1-Nodepools Tests results
-    plugins:
-    - github.com/buildkite-plugins/junit-annotate-buildkite-plugin#v2.4.1:
-        artifacts: work/operator/tests/_e2e_with_flags_artifacts/kuttl-report.xml
-        context: kuttl-v1-nodepools
-        report-slowest: 10
-    soft_fail: true
 

.changes/unreleased/charts-redpanda-Deprecated-20251021-143834.yaml

@@ -0,0 +1,4 @@
+project: charts/redpanda
+kind: Deprecated
+body: '- `statefulset.sideCars.controllers.createRBAC` is deprecated and no longer respected. In most cases, setting this field to `false` would result in a broken deployment. RBAC may be controlled via `rbac.enabled` or per controller via `statefulset.sideCars.controllers.{pvcUnbinder,brokerDecommissioner}.enabled`.'
+time: 2025-10-21T14:38:34.206376-04:00

.changes/unreleased/charts-redpanda-Deprecated-20251021-144413.yaml

@@ -0,0 +1,4 @@
+project: charts/redpanda
+kind: Deprecated
+body: '`statefulset.sideCars.controllers.run` has been unused for many releases and is now deprecated. Individual controllers may be enabled/disabled by setting their enabled field: `statefulset.sideCars.pvcUnbinder.enabled`, `statefulset.sideCars.brokerDecommissioner.enabled`.'
+time: 2025-10-21T14:44:13.331483-04:00

Taskfile.yml

@@ -161,6 +161,11 @@ tasks:
         vars:
           CLI_ARGS: '--load {{.CLI_ARGS}}'
 
+  build:charts:
+    desc: "Run helm dep build for all charts"
+    cmds:
+      - helm dep build ./charts/redpanda/chart
+
   test:unit:
     desc: "Run all unit tests (~5m)"
     vars:
@@ -179,6 +184,7 @@ tasks:
     - task: build:image
       vars:
         CLI_ARGS: '' # Don't forward CLI args to build:image
+    - task: build:charts
     vars:
       RUN: '{{ default `"^TestIntegration"` .RUN }}'
     cmds:
@@ -195,6 +201,7 @@ tasks:
     - task: build:image
       vars:
         CLI_ARGS: '' # Don't forward CLI args to build:image
+    - task: build:charts
     vars:
       RUN: '{{ default `"^TestAcceptance"` .RUN }}'
       GO_TEST_RUNNER: '{{default "go test" .GO_TEST_RUNNER}}'

acceptance/features/helm-chart.feature

@@ -0,0 +1,42 @@
+@operator:none
+Feature: Redpanda Helm Chart
+
+  Scenario: Tolerating Node Failure
+    Given I helm install "redpanda" "../charts/redpanda/chart" with values:
+    ```yaml
+     nameOverride: foobar
+     fullnameOverride: bazquux
+
+     statefulset:
+       sideCars:
+         image:
+           tag: dev
+           repository: localhost/redpanda-operator
+         pvcUnbinder:
+           enabled: true
+           unbindAfter: 15s
+         brokerDecommissioner:
+           enabled: true
+           decommissionAfter: 15s
+    ```
+    When I stop the Node running Pod "bazquux-2"
+    # Wait for the Pod to get evicted from the stopped node.
+    And Pod "bazquux-2" is eventually Pending
+    # Observe that it gets rescheduled.
+    Then Pod "bazquux-2" will eventually be Running
+    # And showcase that ghost brokers have been pruned.
+    And kubectl exec -it "bazquux-0" "rpk redpanda admin brokers list | sed -E 's/\s+/ /gm' | cut -d ' ' -f 1,6" will eventually output:
+    ```
+    ID MEMBERSHIP
+    0 active
+    1 active
+    3 active
+    ```
+    And kubectl exec -it "bazquux-0" "rpk redpanda admin brokers list --include-decommissioned | sed -E 's/\s+/ /gm' | cut -d ' ' -f 1,6" will eventually output:
+    ```
+    ID MEMBERSHIP
+    0 active
+    1 active
+    3 active
+    2 -
+    ```

acceptance/features/migration.feature

@@ -2,7 +2,7 @@ Feature: Helm chart to Redpanda Operator migration
 
   @skip:gke @skip:aks @skip:eks
   Scenario: Migrate from a Helm chart release to a Redpanda custom resource
-        Given a Helm release named "redpanda-migration-example" of the "redpanda/redpanda" helm chart with the values:
+        Given I helm install "redpanda-migration-example" "../charts/redpanda/chart" with values:
         """
     # tag::helm-values[]
         fullnameOverride: name-override

acceptance/features/operator-upgrades.feature

@@ -1,48 +1,8 @@
 @operator:none @vcluster
 Feature: Upgrading the operator
-  @skip:gke @skip:aks @skip:eks
-  Scenario: Operator upgrade from 2.4.5
-    Given I install local CRDs from "../operator/config/crd/bases"
-    And I install redpanda helm chart version "v2.4.5" with the values:
-    """
-    console:
-      enabled: false
-    """
-    And I apply Kubernetes manifest:
-    """
-    ---
-    apiVersion: cluster.redpanda.com/v1alpha2
-    kind: Redpanda
-    metadata:
-      name: operator-upgrade
-    spec:
-      clusterSpec:
-        console:
-          enabled: false
-        statefulset:
-          replicas: 1
-          sideCars:
-            image:
-              tag: dev
-              repository: localhost/redpanda-operator
-    """
-    # use just a Ready status check here since that's all the
-    # old operator supports
-    And cluster "operator-upgrade" is available
-    Then I can upgrade to the latest operator with the values:
-    """
-    image:
-      tag: dev
-      repository: localhost/redpanda-operator
-    crds:
-      experimental: true
-    """
-    # use the new status as this will eventually get set
-    And cluster "operator-upgrade" should be stable with 1 nodes
-
   @skip:gke @skip:aks @skip:eks
   Scenario: Operator upgrade from 25.1.3
-    And I install redpanda helm chart version "v25.1.3" with the values:
+    Given I helm install "redpanda-operator" "redpanda/operator" --version v25.1.3 with values:
     """
     crds:
       enabled: true
@@ -68,7 +28,7 @@ Feature: Upgrading the operator
     # use just a Ready status check here since that's all the
     # old operator supports
     And cluster "operator-upgrade" is available
-    Then I can upgrade to the latest operator with the values:
+    Then I can helm upgrade "redpanda-operator" "../operator/chart" with values:
     """
     image:
       tag: dev