-
Notifications
You must be signed in to change notification settings - Fork 14
operator: add console stanza -> CRD migration #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
76d27d1
[WIP] operator: add console stanza -> CRD migration
chrisseto 53cda40
add partial rendering
andrewstucki 4fcca1c
Add full render and acceptance test
andrewstucki e40a2bf
Fix up unit tests
andrewstucki b3f400b
remove stray namespace
andrewstucki 7be7c4f
Fix acceptance tests and enable Console reconciliation by default
andrewstucki 1e4950a
fix reference names
andrewstucki b9d31c8
swap from console GC to external service
andrewstucki 7411da3
retry on missing console
andrewstucki 2947e8a
Add partial generation for other fields defaulted in values.yaml
andrewstucki 5d21433
Add changelog entry
andrewstucki 0afd9f5
address feedback
andrewstucki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| project: operator | ||
| kind: Deprecated | ||
| body: The entirety of the `spec.clusterSpec.console` block in the Redpanda CR is now deprecated and will be removed in the future. Any Redpanda CR that contains one will automatically be migrated to a standalone Console CR with a back reference to the parent Redpanda CR. Note that these will *not* be automatically deleted when the `console` stanza is removed or when the parent Redpanda CR is deleted. | ||
| time: 2025-11-26T12:05:45.014863-05:00 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| @operator:none | ||
| Feature: Upgrading the operator with Console installed | ||
| @skip:gke @skip:aks @skip:eks | ||
| Scenario: Console v2 to v3 no warnings | ||
| Given I helm install "redpanda-operator" "redpanda/operator" --version v25.1.3 with values: | ||
| """ | ||
| """ | ||
| And I apply Kubernetes manifest: | ||
| """ | ||
| --- | ||
| apiVersion: cluster.redpanda.com/v1alpha2 | ||
| kind: Redpanda | ||
| metadata: | ||
| name: operator-console-upgrade | ||
| spec: | ||
| clusterSpec: | ||
| console: | ||
| # Old versions have broken chart rendering for the console stanza | ||
| # unless nameOverride is set due to mapping configmap values for | ||
| # both the console deployment and redpanda statefulset to the same | ||
| # name. Setting nameOverride to "broken" works around this. | ||
| nameOverride: broken | ||
| tls: | ||
| enabled: false | ||
| external: | ||
| enabled: false | ||
| statefulset: | ||
| replicas: 1 | ||
| sideCars: | ||
| image: | ||
| tag: dev | ||
| repository: localhost/redpanda-operator | ||
| """ | ||
| And cluster "operator-console-upgrade" is available | ||
| Then I can helm upgrade "redpanda-operator" "../operator/chart" with values: | ||
| """ | ||
| image: | ||
| tag: dev | ||
| repository: localhost/redpanda-operator | ||
| crds: | ||
| experimental: true | ||
| """ | ||
| And cluster "operator-console-upgrade" should be stable with 1 nodes | ||
| And the migrated console cluster "operator-console-upgrade" should have 0 warnings | ||
|
|
||
| @skip:gke @skip:aks @skip:eks | ||
| Scenario: Console v2 to v3 with warnings | ||
| Given I helm install "redpanda-operator" "redpanda/operator" --version v25.1.3 with values: | ||
| """ | ||
| """ | ||
| And I apply Kubernetes manifest: | ||
| """ | ||
| --- | ||
| apiVersion: cluster.redpanda.com/v1alpha2 | ||
| kind: Redpanda | ||
| metadata: | ||
| name: operator-console-upgrade-warnings | ||
| spec: | ||
| clusterSpec: | ||
| console: | ||
| nameOverride: broken | ||
| console: | ||
| roleBindings: | ||
| - roleName: admin | ||
| subjects: | ||
| - kind: group | ||
| provider: OIDC | ||
| name: devs | ||
| tls: | ||
| enabled: false | ||
| external: | ||
| enabled: false | ||
| statefulset: | ||
| replicas: 1 | ||
| sideCars: | ||
| image: | ||
| tag: dev | ||
| repository: localhost/redpanda-operator | ||
| """ | ||
| And cluster "operator-console-upgrade-warnings" is available | ||
| Then I can helm upgrade "redpanda-operator" "../operator/chart" with values: | ||
| """ | ||
| image: | ||
| tag: dev | ||
| repository: localhost/redpanda-operator | ||
| crds: | ||
| experimental: true | ||
| """ | ||
| And cluster "operator-console-upgrade-warnings" should be stable with 1 nodes | ||
| And the migrated console cluster "operator-console-upgrade-warnings" should have 1 warning |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.