-
Notifications
You must be signed in to change notification settings - Fork 15
Stage console, redpanda, and operator releases #1194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RafalKorepta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like this PR to point to release/v25.2.x release branch.
This stages the releases for Console 3.3.0, Redpanda 25.2.1, and Operator 25.2.1 charts. As upstream Console changed some its Go versioning and requires go 1.25, this also updates our go version and all of the nix tooling that is involved. (cherry picked from commit 71dada0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This stages the releases for Console 3.3.0, Redpanda 25.2.1, and Operator 25.2.1 charts. As upstream Console changed some its Go versioning and requires go 1.25, this also updates our go version and all of the nix tooling that is involved. (cherry picked from commit 71dada0) Co-authored-by: Andrew Stucki <[email protected]>
| { buildGo124Module, lib, fetchFromGitHub }: | ||
|
|
||
| buildGoModule rec { | ||
| buildGo124Module rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you don't update controller-tools?
I did this in
| version = "0.19.0"; |
| postInstall = lib.optionalString (stdenv.buildPlatform.canExecute stdenv.hostPlatform) '' | ||
| installShellCompletion --cmd go-licenses \ | ||
| --bash <("$out/bin/go-licenses" completion bash) \ | ||
| --fish <("$out/bin/go-licenses" completion fish) \ | ||
| --zsh <("$out/bin/go-licenses" completion zsh) | ||
| # workaround empty output when GOROOT differs from built environment | ||
| # see https://github.com/google/go-licenses/issues/149 | ||
| wrapProgram "$out/bin/go-licenses" \ | ||
| --set GOROOT '${go}/share/go' | ||
| ''; | ||
|
|
||
| doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not necessary
I would not be surprised if I forgot to update something some place. That said, this stages things so we can cut releases of all of these.