Skip to content

Enable shadow links by default #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewstucki merged 1 commit into from
Dec 11, 2025
Merged

Enable shadow links by default #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/unreleased/operator-Added-20251210-121913.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
project: operator
kind: Added
body: ShadowLink CRD for controlling 25.3 shadow link settings. See documentation for details.
time: 2025-12-10T12:19:13.689549-05:00
2 changes: 1 addition & 1 deletion operator/cmd/crd/crd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ var (
crds.Redpanda(),
crds.Role(),
crds.Schema(),
crds.ShadowLink(),
crds.Topic(),
crds.User(),
}
Expand All @@ -44,7 +45,6 @@ var (
}
experimentalCRDs = []*apiextensionsv1.CustomResourceDefinition{
crds.NodePool(),
crds.ShadowLink(),
}
schemes = []func(s *runtime.Scheme) error{
clientgoscheme.AddToScheme,
Expand Down
12 changes: 4 additions & 8 deletions operator/cmd/run/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ type RunOptions struct {
enableRedpandaControllers bool

enableV2NodepoolController bool
enableShadowLinksController bool
enableConsoleController bool
managerOptions ctrl.Options
clusterDomain string
Expand Down Expand Up @@ -141,7 +140,6 @@ func (o *RunOptions) BindFlags(cmd *cobra.Command) {
// Controller flags.
cmd.Flags().BoolVar(&o.enableConsoleController, "enable-console", true, "Specifies whether or not to enabled the redpanda Console controller")
cmd.Flags().BoolVar(&o.enableV2NodepoolController, "enable-v2-nodepools", false, "Specifies whether or not to enabled the v2 nodepool controller")
cmd.Flags().BoolVar(&o.enableShadowLinksController, "enable-shadowlinks", false, "Specifies whether or not to enabled the shadow links controller")
cmd.Flags().BoolVar(&o.enableVectorizedControllers, "enable-vectorized-controllers", false, "Specifies whether or not to enabled the legacy controllers for resources in the Vectorized Group (Also known as V1 operator mode)")
cmd.Flags().BoolVar(&o.enableRedpandaControllers, "enable-redpanda-controllers", true, "Specifies whether or not to enabled the Redpanda cluster controllers")
cmd.Flags().StringVar(&o.clusterDomain, "cluster-domain", "cluster.local", "Set the Kubernetes local domain (Kubelet's --cluster-domain)")
Expand Down Expand Up @@ -185,6 +183,7 @@ func (o *RunOptions) BindFlags(cmd *cobra.Command) {
cmd.Flags().Bool("force-defluxed-mode", false, "A deprecated and unused flag")
cmd.Flags().Bool("allow-pvc-deletion", false, "Deprecated: Ignored if specified")
cmd.Flags().Bool("operator-mode", true, "A deprecated and unused flag")
cmd.Flags().Bool("enable-shadowlinks", false, "Specifies whether or not to enabled the shadow links controller")
}

func (o *RunOptions) ControllerEnabled(controller Controller) bool {
Expand Down Expand Up @@ -440,12 +439,9 @@ func Run(
}
}

// ShadowLink Reconciler
if opts.enableShadowLinksController {
if err := redpandacontrollers.SetupShadowLinkController(ctx, mgr, cloudExpander, v1Controllers, v2Controllers); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "ShadowLink")
return err
}
if err := redpandacontrollers.SetupShadowLinkController(ctx, mgr, cloudExpander, v1Controllers, v2Controllers); err != nil {
setupLog.Error(err, "unable to create controller", "controller", "ShadowLink")
return err
}

if err := redpandacontrollers.SetupTopicController(ctx, mgr, cloudExpander, v1Controllers, v2Controllers); err != nil {
Expand Down
Loading