Change leader election to run in kube-system namespace when cluster-scoped and namespace is unspecified #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes K8S-734
Prior to this commit when namespace is unspecified, then we wind up with:
as our default value in our leader election options handed to the controller-runtime manager due to
opts.namespacenot being set (as we're cluster-scoped).When that's set to an empty string, the controller-runtime attempts to automatically detect the running namespace of the container via calling:
and using that. What this means is that we have no enforcement mechanism for making the operator unable to run multiple cluster-scoped controllers simultaneously. Moving the lease namespace to
kube-systemenables all cluster-scoped operators by default to attempt the same lease lock, causing only a single operator to grab the leader election lock and run its controllers at any given time.