Skip to content

operator v1: do not decom broker if it's missing in RP #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RafalKorepta merged 1 commit into from
Nov 19, 2024
Merged

operator v1: do not decom broker if it's missing in RP #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions operator/pkg/resources/statefulset_scale.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,23 @@ func (r *StatefulSetResource) handleScaling(ctx context.Context) error {
podName := fmt.Sprintf("%s-%d", r.LastObservedState.Name, targetOrdinal)
log.WithValues("pod", podName, "ordinal", targetOrdinal, "node_id", targetBroker).Info("start decommission broker")

// Make sure the broker we want to decommission actually exists in redpanda itself.
// If not, error out, it is not a supported condition, and could be result of a stale read of status.nodePools[*].currentReplicas.
adminClient, err := r.getAdminAPIClient(ctx)
if err != nil {
return fmt.Errorf("failed to create admin API client: %w", err)
}
broker, err := getBrokerByBrokerID(ctx, *targetBroker, adminClient)
if err != nil {
return fmt.Errorf("failed to get broker by broker ID: %w", err)
}
if broker == nil {
return &RequeueAfterError{
RequeueAfter: RequeueDuration,
Msg: fmt.Sprintf("attempting to decommission broker %d, but redpanda reports that it does not exist", *targetBroker),
}
}

err = retry.RetryOnConflict(retry.DefaultRetry, func() error {
cluster := &vectorizedv1alpha1.Cluster{}
err := r.Get(ctx, types.NamespacedName{
Expand Down