gen: fix partial generation of embedded structs#513
Merged
Conversation
Prior to this commit `gen partial` would incorrectly handle embedded structs by adding them as top level fields. The issue was due to using a limited method of creating the underlying `types.Field`. This commit corrects the generation and adds a regression test.
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
RafalKorepta
approved these changes
Mar 11, 2025
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit
gen partialwould incorrectly handle embedded structs by adding them as top level fields.The issue was due to using a limited method of creating the underlying
types.Field.This commit corrects the generation and adds a regression test.