Conversation
|
|
4baf000 to
41ad116
Compare
35f1861 to
26d1b15
Compare
chrisseto
left a comment
There was a problem hiding this comment.
LGTM!
However, the added imports (Looking at you OTEL) might cause some conflicts in the operator. Ahead of merging, would you mind trying to build the operator with this change? Just add a replace directive to the operators go.mod and run task build, that should let us know if there's any version conflicts we'll have to dance around.
In my experience most google libraries, proto libraries, and otel have a tendency to make dependency management very painful.
26d1b15 to
63c35bf
Compare
(cherry picked from commit 7963626)
(cherry picked from commit 7963626)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 7963626)
(cherry picked from commit 7963626)
(cherry picked from commit 7963626)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit 7963626) # Conflicts: # pkg/go.mod
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This will allow us to implement expansion of secrets.
The MaybeExpand can be dropped later, once we switch to jan's new api. It's just for experimentation with passing in the interpolated value.