Skip to content

Comments

pkg: add expander for cloud secrets#519

Merged
alenkacz merged 1 commit intomainfrom
av/cloud-secrets
Mar 13, 2025
Merged

pkg: add expander for cloud secrets#519
alenkacz merged 1 commit intomainfrom
av/cloud-secrets

Conversation

@alenkacz
Copy link
Contributor

This will allow us to implement expansion of secrets.

The MaybeExpand can be dropped later, once we switch to jan's new api. It's just for experimentation with passing in the interpolated value.

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@alenkacz alenkacz force-pushed the av/cloud-secrets branch 5 times, most recently from 35f1861 to 26d1b15 Compare March 13, 2025 08:19
Copy link
Contributor

@chrisseto chrisseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, the added imports (Looking at you OTEL) might cause some conflicts in the operator. Ahead of merging, would you mind trying to build the operator with this change? Just add a replace directive to the operators go.mod and run task build, that should let us know if there's any version conflicts we'll have to dance around.

In my experience most google libraries, proto libraries, and otel have a tendency to make dependency management very painful.

@jan-g
Copy link
Contributor

jan-g commented Apr 2, 2025

💚 All backports created successfully

Status Branch Result
release/v2.4.x
release/v2.3.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

RafalKorepta pushed a commit that referenced this pull request Apr 2, 2025
RafalKorepta pushed a commit that referenced this pull request Apr 2, 2025
alenkacz added a commit that referenced this pull request Apr 2, 2025
@alenkacz
Copy link
Contributor Author

alenkacz commented Apr 2, 2025

💚 All backports created successfully

Status Branch Result
release/v25.1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jan-g pushed a commit that referenced this pull request Apr 4, 2025
(cherry picked from commit 7963626)

# Conflicts:
#	pkg/go.mod
@jan-g
Copy link
Contributor

jan-g commented Apr 4, 2025

💚 All backports created successfully

Status Branch Result
release/v25.1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants