[release/v2.3.x] gotohelm: support struct embedding in helmette.Unwrap#522
Merged
chrisseto merged 1 commit intorelease/v2.3.xfrom Mar 12, 2025
Merged
Conversation
Prior to this commit, `helmette.Unwrap` would incorrectly handle embedded structs when run from go. Our usage of the `mapstructure` library was not configured to respect struct embeddings and the previously used version wasn't actually able to manage them in a useful way. This commit updates `mapstructure` to the blessed fork from go-viper and configures it to respect struct embeddings with unofficial `json:",inline"` tag which matches the behavior of gotohelm in helm mode. (cherry picked from commit 82ff3a1)
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
RafalKorepta
approved these changes
Mar 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintorelease/v2.3.x:helmette.UnwrapQuestions ?
Please refer to the Backport tool documentation