Conversation
4cdee15 to
2c4065e
Compare
Contributor
Author
|
Waiting on #510 to merge |
2c4065e to
72a2125
Compare
bojand
approved these changes
Mar 14, 2025
72a2125 to
aae5e99
Compare
Contributor
There was a problem hiding this comment.
First the charts/redpanda needs to bump charts/console go depedency to unreleased v3.0.0 version. gen package rightly shows compilation error, because replace directive removes few fields that console.tpl.go is using. When I tried to fix it I stopped at console values that are null, but schema does not allow it.
Few examples from unit tests
Error Trace: /Users/rafalkorepta/workspace/redpanda/redpanda-operator/charts/console/chart_test.go:88
Error: Received unexpected error:
values don't meet the specifications of the schema(s) in the following chart(s):
console:
- service.targetPort: Invalid type. Expected: integer, given: null
- ingress.className: Invalid type. Expected: string, given: null
Test: TestTemplate/autoscaling-memory
Error Trace: /Users/rafalkorepta/workspace/redpanda/redpanda-operator/charts/console/chart_test.go:88
Error: Received unexpected error:
values don't meet the specifications of the schema(s) in the following chart(s):
console:
- podSecurityContext.fsGroupChangePolicy: podSecurityContext.fsGroupChangePolicy must be one of the following: "OnRootMismatch", "Always"
Test: TestTemplate/case-049
I only saw JSONSchemaExtend function on specific type that allows to overwrite mentioned properties:
schema.Properties.Set(key, &jsonschema.Schema{
OneOf: []*jsonschema.Schema{
prop,
{Type: "null"},
},
})
This commit configures CI to push nightly builds of the console chart to the console-unstable docker repository to aid in the release of console V3.
aae5e99 to
e3f67b1
Compare
RafalKorepta
approved these changes
Mar 17, 2025
Contributor
Author
|
I've pulled out the schema changes for now as they carry some additional complications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit configures CI to push nightly builds of the console chart to the console-unstable docker repository to aid in the release of console V3.
Additionally, this commit adds schema generation to the console chart to prevent usage of out of date values files.