Skip to content

Comments

console: add nightly builds#531

Merged
chrisseto merged 1 commit intomainfrom
chris/p/console-nightly
Mar 17, 2025
Merged

console: add nightly builds#531
chrisseto merged 1 commit intomainfrom
chris/p/console-nightly

Conversation

@chrisseto
Copy link
Contributor

This commit configures CI to push nightly builds of the console chart to the console-unstable docker repository to aid in the release of console V3.

Additionally, this commit adds schema generation to the console chart to prevent usage of out of date values files.

@chrisseto
Copy link
Contributor Author

Waiting on #510 to merge

@chrisseto chrisseto force-pushed the chris/p/console-nightly branch from 2c4065e to 72a2125 Compare March 14, 2025 21:42
@RafalKorepta RafalKorepta force-pushed the chris/p/console-nightly branch from 72a2125 to aae5e99 Compare March 17, 2025 05:42
Copy link
Contributor

@RafalKorepta RafalKorepta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the charts/redpanda needs to bump charts/console go depedency to unreleased v3.0.0 version. gen package rightly shows compilation error, because replace directive removes few fields that console.tpl.go is using. When I tried to fix it I stopped at console values that are null, but schema does not allow it.

Few examples from unit tests

        	Error Trace:	/Users/rafalkorepta/workspace/redpanda/redpanda-operator/charts/console/chart_test.go:88
        	Error:      	Received unexpected error:
        	            	values don't meet the specifications of the schema(s) in the following chart(s):
        	            	console:
        	            	- service.targetPort: Invalid type. Expected: integer, given: null
        	            	- ingress.className: Invalid type. Expected: string, given: null
        	Test:       	TestTemplate/autoscaling-memory
        	Error Trace:	/Users/rafalkorepta/workspace/redpanda/redpanda-operator/charts/console/chart_test.go:88
        	Error:      	Received unexpected error:
        	            	values don't meet the specifications of the schema(s) in the following chart(s):
        	            	console:
        	            	- podSecurityContext.fsGroupChangePolicy: podSecurityContext.fsGroupChangePolicy must be one of the following: "OnRootMismatch", "Always"
        	Test:       	TestTemplate/case-049

I only saw JSONSchemaExtend function on specific type that allows to overwrite mentioned properties:

		schema.Properties.Set(key, &jsonschema.Schema{
			OneOf: []*jsonschema.Schema{
				prop,
				{Type: "null"},
			},
		})

This commit configures CI to push nightly builds of the console chart to the
console-unstable docker repository to aid in the release of console V3.
@chrisseto chrisseto force-pushed the chris/p/console-nightly branch from aae5e99 to e3f67b1 Compare March 17, 2025 15:13
@chrisseto chrisseto changed the title console: add nightly builds and schema gen console: add nightly builds Mar 17, 2025
@chrisseto
Copy link
Contributor Author

I've pulled out the schema changes for now as they carry some additional complications.

@chrisseto chrisseto enabled auto-merge (rebase) March 17, 2025 15:30
@chrisseto chrisseto merged commit 33e4894 into main Mar 17, 2025
12 checks passed
@RafalKorepta RafalKorepta deleted the chris/p/console-nightly branch March 28, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants