Skip to content

Comments

formalize new versioning scheme and fix console nightlies#536

Merged
chrisseto merged 1 commit intomainfrom
chris/p/fix-console-nightly
Mar 21, 2025
Merged

formalize new versioning scheme and fix console nightlies#536
chrisseto merged 1 commit intomainfrom
chris/p/fix-console-nightly

Conversation

@chrisseto
Copy link
Contributor

@chrisseto chrisseto commented Mar 18, 2025

This commit formalizes the new version format of $MAJOR.$MINOR-k8s$PATCH for
releases v25.1 and forwards.

Changie has been configured to refer to versions in their semver format but
will replace them with their -k8s alternative in the CHANGELOG itself.

Version stamping has been moved to ./ci/script/version.sh which provides a
variety of options.

./ci/scripts/version.sh charts/console -e  # v3.0-k8s0-beta.1-1-g760a015f
./ci/scripts/version.sh charts/console     # v3.0.0-beta.1-1-g760a015f
./ci/scripts/version.sh charts/redpanda    # v5.9.20-66-g92c19f4b
./ci/scripts/version.sh charts/redpanda -e # v5.9-k8s20-66-g92c19f4b

@chrisseto
Copy link
Contributor Author

I think this will have to wait on #537 so I can cut a tag for the module and which will fix the version stamping in CI.

@chrisseto chrisseto force-pushed the chris/p/fix-console-nightly branch 5 times, most recently from 0285b49 to 5c01371 Compare March 20, 2025 21:15
@chrisseto chrisseto marked this pull request as ready for review March 20, 2025 21:16
@chrisseto chrisseto changed the title Fix Console Chart Nightly Builds formalize new versioning scheme and fix console nightlies Mar 20, 2025
vars: {REPO: console-unstable, CHART: console, VERSION: "{{ .CONSOLE_CHART_VERSION }}"}

publish:nightly:helm:chart:
run: 'always'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious is that explicit run: 'always' is used to call ci:publish:nightly:helm:chart more than once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taskfile's caching is kinda weird. There's a setting in the root taskfile to only run ever task once. This task will run once for every helm chart we want to publish (currently operator + console). Setting the label to be dynamic is supposed to make this task run once be unique label, but that didn't seem to work :/ So instead, we have to set it to run every time, which kinda makes sense for a build script any how?

@RafalKorepta
Copy link
Contributor

Please run go test -update in console chart.

This commit formalizes the new version format of `$MAJOR.$MINOR-k8s$PATCH` for
releases v25.1 and forwards.

Changie has been configured to refer to versions in their semver format but
will replace them with their `-k8s` alternative in the CHANGELOG itself.

Version stamping has been moved to `./ci/script/version.sh` which provides a
variety of options.

```bash
./ci/scripts/version.sh charts/console -e  # v3.0-k8s0-beta.1-1-g760a015f
./ci/scripts/version.sh charts/console     # v3.0.0-beta.1-1-g760a015f
./ci/scripts/version.sh charts/redpanda    # v5.9.20-66-g92c19f4b
./ci/scripts/version.sh charts/redpanda -e # v5.9-k8s20-66-g92c19f4b
```
@chrisseto chrisseto force-pushed the chris/p/fix-console-nightly branch from 5c01371 to e9bdafe Compare March 21, 2025 13:55
@chrisseto chrisseto merged commit 572c737 into main Mar 21, 2025
12 checks passed
@chrisseto chrisseto deleted the chris/p/fix-console-nightly branch March 21, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants