Remove availableReplicas check for old DecommissionController#545
Merged
andrewstucki merged 1 commit intomainfrom Mar 20, 2025
Merged
Remove availableReplicas check for old DecommissionController#545andrewstucki merged 1 commit intomainfrom
andrewstucki merged 1 commit intomainfrom
Conversation
andrewstucki
requested review from
RafalKorepta,
chrisseto and
gene-redpanda
as code owners
chrisseto
approved these changes
Mar 20, 2025
Contributor
chrisseto
left a comment
chrisseto
left a comment
There was a problem hiding this comment.
This controller is so fragile 😬
andrewstucki
added a commit
that referenced
this pull request
Mar 20, 2025
(cherry picked from commit bb95984)
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
RafalKorepta
pushed a commit
that referenced
this pull request
Mar 21, 2025
(cherry picked from commit bb95984)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this was causing our e2e v2 tests to fail the decommissioning test.
The logic basically says, "make sure I have 0 available replicas before attempting a decommission" -- in other words every broker must be marked as "not ready" for a decommission to happen with the old decommission controller. This isn't the way that the new decommissioner works and I'm amenable to plumbing in the new decommissioner sooner than later, but this is to just get our decommissioning tests to pass as this guard should be unnecessary and never will actually happen with the relaxed health checks (i.e. we'll never be in a state where all nodes are marked unhealthy since they tolerate potential
node_downstates).