Skip to content

[release/v2.3.x] Remove availableReplicas check (#545) #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RafalKorepta merged 1 commit into from
Mar 21, 2025
Merged

[release/v2.3.x] Remove availableReplicas check (#545) #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions operator/internal/controller/redpanda/redpanda_decommission_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,13 +315,6 @@ func (r *DecommissionReconciler) reconcileDecommission(ctx context.Context, log
return ctrl.Result{Requeue: true, RequeueAfter: 10 * time.Second}, nil
}

// This helps avoid decommissioning nodes that are starting up where, say, a node has been removed
// and you need to move it and start a new one
if availableReplicas != 0 {
log.Info("have not reached steady state yet, requeue here")
return ctrl.Result{Requeue: true, RequeueAfter: 10 * time.Second}, nil
}

valuesMap, err := getHelmValues(ctx, r, log, releaseName, namespace, r.OperatorMode)
if err != nil {
return ctrl.Result{}, fmt.Errorf("could not retrieve values, probably not a valid managed helm release: %w", err)
Expand Down