Fix up config hash calculations to not involve unhashable fields that change based on replicas#559
Merged
andrewstucki merged 3 commits intomainfrom Mar 25, 2025
Merged
Conversation
andrewstucki
requested review from
RafalKorepta,
chrisseto and
gene-redpanda
as code owners
chrisseto
approved these changes
Mar 21, 2025
Contributor
… change based on replicas
andrewstucki
force-pushed
the
as/fix-config-hash
branch
from
d786f52 to
ba7b76e
Compare
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure why the
go.modfiles got updated when I rantask generate -f-- I'm assuming it has something to do withgo mod tidyruns? Either way, this fixes the issue with pods restarting based off of StatefulSet replicas changing.Previously what was occurring is that the list of brokers placed in "client" sections of our
redpanda.yamlwere being included in the hash calculations, because the number of brokers changes the list of brokers, any change to the number of replicas was resulting in the hash change and hence causing the brokers to get rolling restarted. This excludes "client" portions of the config from the hash calculation.