Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
andrewstucki
approved these changes
Mar 21, 2025
A recent change added the `{{ .PACKAGE }}` selector to the `go:build` command
but neglected to update the command in `status`. This caused `gotohelm` to not
be rebuilt as expected leading to exciting new build errors.
This commit updates the status check.
chrisseto
force-pushed
the
chris/p/fix-task-build-caching
branch
from
59ed5c0 to
4dd364e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent change added the
{{ .PACKAGE }}selector to thego:buildcommand but neglected to update the command instatus. This causedgotohelmto not be rebuilt as expected leading to exciting new build errors.This commit updates the status check.