operator: Return errors with stacktrace#573
Merged
RafalKorepta merged 1 commit intomainfrom Mar 27, 2025
Merged
Conversation
During debuging of fullnameOverride the error was too general to reason about the place where it happen. This change replace almost all naked `err` case with `errors.WithStack(err)`.
RafalKorepta
requested review from
andrewstucki,
chrisseto and
gene-redpanda
as code owners
chrisseto
approved these changes
Mar 27, 2025
Contributor
Author
|
@chrisseto Do you want this change to backport too? |
Contributor
|
If easy, yes please |
This was referenced Mar 27, 2025
Contributor
Author
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During debuging of fullnameOverride the error was too general to reason about
the place where it happen. This change replace almost all naked
errcase witherrors.WithStack(err).