operator: default useFlux to false#588
Merged
chrisseto merged 1 commit intorelease/v2.4.xfrom Mar 28, 2025
Merged
Conversation
chrisseto
requested review from
RafalKorepta,
andrewstucki and
gene-redpanda
as code owners
Contributor
RafalKorepta
left a comment
RafalKorepta
left a comment
There was a problem hiding this comment.
LGTM just the unit test have typo
|
|
||
| require.Containsf( | ||
| t, | ||
| recursiveProperties["spec"].Properties["chartRef"].Properties["chartversion"].Description, |
Contributor
There was a problem hiding this comment.
Suggested change
| recursiveProperties["spec"].Properties["chartRef"].Properties["chartversion"].Description, | |
| recursiveProperties["spec"].Properties["chartRef"].Properties["chartVersion"].Description, |
RafalKorepta
approved these changes
Mar 28, 2025
chrisseto
force-pushed
the
chris/p/no-use-flux
branch
2 times, most recently
from
2292d7b to
c2581ae
Compare
JakeSCahill
reviewed
Mar 28, 2025
Contributor
JakeSCahill
left a comment
JakeSCahill
left a comment
There was a problem hiding this comment.
Some text suggestions
This commit removes the beta warning on `useFlux`, changes the interpretation of `useFlux: null` to `false`, and bounds `chartVersion` to charts in the v5.9.x and v5.10.x series.
chrisseto
force-pushed
the
chris/p/no-use-flux
branch
from
0b75216 to
6f95bdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the beta warning on
useFlux, changes the interpretation ofuseFlux: nulltofalse, and boundschartVersionto charts in the v5.9.x and v5.10.x series.