annotate broker on config change

[simon0191]

Annotate brokers with cluster config version to force a restart on config changes

Refs

• restart redpanda on changes to the cluster configuration #603 (comment)

[RafalKorepta]

I see one important test missing. When you have StatefulSet it would be good to assert in the test you changed that Pod generation roll over.

[RafalKorepta]

I wrongly guide you. Pods does not have generation. Higher level resources like StatefulSet and Deployment have such generation. Pods have only labels and resourceVersion and uid in metadata.

Maybe only one change I would make is to not change the assertion, but rather when the Condition is set to True. As far as I understand

	syncer := syncclusterconfig.Syncer{Client: client, Mode: syncclusterconfig.SyncerModeAdditive}
	configVersion, err := syncer.Sync(ctx, config, usersTXT)
	if err != nil {
		return errors.WithStack(err)
	}

	apimeta.SetStatusCondition(rp.GetConditions(), metav1.Condition{
		Type:               redpandav1alpha2.ClusterConfigSynced,
		Status:             metav1.ConditionTrue,
		ObservedGeneration: rp.Generation,
		Reason:             "ConfigSynced",
		Message:            fmt.Sprintf("ClusterConfig at Version %d", configVersion),
	})

will set the condition when Pods did not restart. Am I right?

[jan-g]

As long as the forced restart by applying a new/changed configuration doesn't cause a config version bump (I don't think it does, having just tried it) I think this approach is okay.

[chrisseto]

I think we'll want to include this in main and backport it to v2.4.x and v2.3.x? WDYT?

Implementation LGTM, just a couple things to fix up in tests.

[chrisseto]

LGTM! You need to run task lint -- --fix to get the linter to approve you.

[simon0191]

💚 All backports created successfully

Status	Branch	Result
✅	release/v2.4.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[simon0191]

💚 All backports created successfully

Status	Branch	Result
✅	release/v2.4.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[simon0191]

💚 All backports created successfully

Status	Branch	Result
✅	release/v2.4.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation